build: add missing attributes to Win installer #18059

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:win_installer_attributes changing 1 files +2 −2

fanquake commented at 6:22 AM on February 3, 2020: member

Fixes: #17170.
fanquake added the label Windows on Feb 3, 2020
fanquake added the label Build system on Feb 3, 2020
fanquake added the label Needs gitian build on Feb 3, 2020

in share/setup.nsi.in:62 in 6a9fd7c71c outdated

  57 | @@ -58,8 +58,8 @@ VIAddVersionKey ProductVersion "@PACKAGE_VERSION@"
  58 |  VIAddVersionKey CompanyName "${COMPANY}"
  59 |  VIAddVersionKey CompanyWebsite "${URL}"
  60 |  VIAddVersionKey FileVersion "@PACKAGE_VERSION@"
  61 | -VIAddVersionKey FileDescription ""
  62 | -VIAddVersionKey LegalCopyright ""
  63 | +VIAddVersionKey FileDescription "Installer for @PACKAGE_NAME@"
  64 | +VIAddVersionKey LegalCopyright "@COPYRIGHT_HOLDERS_FINAL@"

hebasto commented at 5:09 PM on February 3, 2020:

fanquake commented at 2:48 AM on February 4, 2020:

I don't really care, but sure.

hebasto commented at 5:10 PM on February 3, 2020: member

Concept ACK.

DrahtBot commented at 11:18 PM on February 3, 2020: member

Gitian builds

File	commit 365c83e6a8399913cec5f0383978c28f8418fa3b<br>(master)	commit 906981e24859b42ae2c11202dde1a71151c41330<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`970e730072cb3102...`	`d6d6271b47571b6b...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`935312465c6da174...`	`967b6befdf2863ba...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`0ed6a37c55b14a2e...`	`282ea5ad10f3e7d6...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`028f778eb4927763...`	`fdf0f7baeb54b670...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`1db644cdfe7214fb...`	`4e663f8098389c8f...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`287253ed7574eaea...`	`63fc635e8c0a0024...`
bitcoin-0.19.99-osx-unsigned.dmg	`821863528e68ec86...`	`b1309ddfbb266a71...`
bitcoin-0.19.99-osx64.tar.gz	`1786b62a871209a2...`	`5b03ac51d3189ea9...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`22d076616e4c906e...`	`894633c9b81dc671...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`c28b4fa1737df120...`	`a891e66fff93680b...`
bitcoin-0.19.99-win64-debug.zip	`b9cae2f4ecb811b5...`	`6b8c071d0c7456d5...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`33d162f55ec7a280...`	`a4720f619dd785d8...`
bitcoin-0.19.99-win64.zip	`2e9c7f3b6a81a019...`	`1a1eb4cdf2d24184...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`c6d3a034928bf42f...`	`8467bb53c565305b...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`3398c21d3cc2db4a...`	`5f497595c5d6b1dc...`
bitcoin-0.19.99.tar.gz	`53fdfce17dfd576e...`	`07a590e7ae14e4db...`
bitcoin-core-linux-0.20-res.yml	`5e3e3dc9d073bfe0...`	`288266c671217167...`
bitcoin-core-osx-0.20-res.yml	`bb414d323b8702a3...`	`147de773a14b89fe...`
bitcoin-core-win-0.20-res.yml	`713d925b71fce216...`	`cb20a16ddd529ecc...`
linux-build.log	`0fa8aec26c2484b6...`	`a1810e9b0347a0cd...`
osx-build.log	`1e49555bff5faba3...`	`243bdfa3e3355f46...`
win-build.log	`e61928f15b54a519...`	`9aa9a7d29c8ddd6e...`
bitcoin-core-linux-0.20-res.yml.diff		`5a3e352e46164a38...`
bitcoin-core-osx-0.20-res.yml.diff		`59e0d9bd4c6a6056...`
bitcoin-core-win-0.20-res.yml.diff		`4abcd6240cf2ae95...`
linux-build.log.diff		`f12a21d5caed6e0e...`
osx-build.log.diff		`5b6365ad399b0302...`
win-build.log.diff		`94483c73a8bc0a4b...`

DrahtBot removed the label Needs gitian build on Feb 3, 2020
build: add additional attributes to Win installer 6c22315223
fanquake force-pushed on Feb 4, 2020
luke-jr commented at 6:06 AM on February 4, 2020: member

utACK
hebasto commented at 8:07 AM on February 4, 2020: member

ACK 6c223152238d2e818e38357b03f38a4dbe9de016, I have reviewed the code and it looks OK, I agree it can be merged.
fanquake referenced this in commit a064e005fa on Feb 5, 2020
fanquake merged this on Feb 5, 2020
fanquake closed this on Feb 5, 2020
fanquake deleted the branch on Feb 5, 2020
MarkLTZ referenced this in commit af609c51ca on Apr 19, 2020
MarkLTZ referenced this in commit 3b4c747eaa on Apr 19, 2020
PastaPastaPasta referenced this in commit bb142df26b on Jun 27, 2021
PastaPastaPasta referenced this in commit c42a1d225f on Jun 28, 2021
PastaPastaPasta referenced this in commit ff1de6382f on Jun 29, 2021
PastaPastaPasta referenced this in commit 581d5408ad on Jul 1, 2021
PastaPastaPasta referenced this in commit 9ccdb9c42e on Jul 1, 2021
PastaPastaPasta referenced this in commit b3ff351c68 on Jul 14, 2021
PastaPastaPasta referenced this in commit 1340a51e1b on Jul 14, 2021
random-zebra referenced this in commit 3614de632e on Jul 19, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#17170 Windows installer properties and signing