According to #17178 by MarcoFalke, cd command (using for changing directory) has some conflicts with Travis builtin command with similar name in some environments (like macOS).
In this PR :
cd by type cd in ci/test/06_script_a.sh and ci/test/06_script_b.sh .safe_cd as commented in here to avoid duplication in code.
safe_cd is a reasonable workaround. But I would change the PR title, because it doesn’t really “solve” the problem.
I’m OK with this if it solves a problem.
But to be honest I think this is terrible. Even a basic command that has existed since the 70’s like cd needs a workaround these days? This makes it impossible to do shell scripting sanely. Are you going to review new code for using the right cd variant?
5@@ -6,6 +6,18 @@
6
7 export LC_ALL=C.UTF-8
8
9+lcd=cd
10+if [[ "$OSTYPE" == "darwin"* ]]; then
11+ lcd=type cd
12+fi
13+
14+safe_cd()
I’m OK with this if it solves a problem.
But to be honest I think this is terrible. Even a basic command that has existed since the 70’s like
cdneeds a workaround these days? This makes it impossible to do shell scripting sanely. Are you going to review new code for using the rightcdvariant?
Unfortunately Travis CI is in it’s Betha version and has several bugs in macOS environment.
In this specific issue, i am going to use type cd instead of cd in macOS and continue using cd for other operating systems.
In macOS, Travis considers cd command as it’s built-in Travis command and not as a shell scripting command :cry:.
In macOS, Travis considers cd command as it’s built-in Travis command and not as a shell scripting command cry.
why? is there any documention available? What would happen if we forced it to use the shell built in?
In macOS, Travis considers cd command as it’s built-in Travis command and not as a shell scripting command cry.
why? is there any documention available? What would happen if we forced it to use the shell built in?
I really don’t know :disappointed: I searched for a document for this specific issue, but i didn’t find one. Actually there is some issues in Travis repository like this that concerns about similar problem.
How can i force Travis to use shell built in? Any help will be appreciated :hand:
which cd, type cd and command -v cd?
How can i force Travis to use shell built in?
We should use which / type as marco suggested to actually debug this and figure out the problem so it can be fixed upstream. But replacing cd with command cd would force using the built in.
How can i force Travis to use shell built in?
We should use
which/typeas marco suggested to actually debug this and figure out the problem so it can be fixed upstream. But replacingcdwithcommand cdwould force using the built in.
Thank you for your help :+1:
So i am going to use command cd instead of cd in all OSs(including macOs and …) and use type cd before any usage of command cd in code for future debug in upstream.
Did i understand you right?
type cd and which cd is, there is nothing we can do
https://travis-ci.org/bitcoin/bitcoin/jobs/601781884#L228
says
0cd is a function
1
2cd ()
3
4{
5
6 __zsh_like_cd cd "$@"
7
8}
cd? Can we use pushd maybe?
Anyone has any idea how to overwrite this
cd? Can we usepushdmaybe?
pushd probably won’t help: https://github.com/rvm/rvm/blob/ad02fb2c7ae77c7fd92a4f68766a2c8140766d08/scripts/cd#L14-L16
I think we should debug this further (maybe turn on set -x or look at type __zsh_like_cd output) and figure out why the __zsh_like_cd function is dying on mac with errexit, then report the issue to travis so it can be fixed, and in the meantime add a safe_cd function that either calls command cd or just toggles errexit before calling regular cd.
Good find @ryanofsky
So upgrading to 1.29.9 (https://github.com/rvm/rvm/commit/8a3bf6a12f560c3b415224c5d6d6c195715fc59d) should fix this.
See here: https://rvm.io/rvm/upgrading
pushd definitely doesn’t help; I tried that before.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.