wallet: Remove unused GetLabelName #17203

While taking a look at #17198 I noticed that the method CWallet::GetLabelName(...) is not used anymore, since the account API was removed (c9c32e6b844fc79467b7e24c6c916142a0d08484).

ACK 7ca68e1461376afc22a26268c80a7281522ed9eb

Very good catch! :)

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #16341 (Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Very good catch! :)

Thanks for providing the regex and the review. I guess if a function is not called at all this is also kind of a "lifetime issue" :stuck_out_tongue_closed_eyes:

ACK 7ca68e1461376afc22a26268c80a7281522ed9eb.

ACK 7ca68e1461376afc22a26268c80a7281522ed9eb

@theStack If you want to remove dead code you might want to take a look at #17130 (comment) too :)

@theStack If you want to remove dead code you might want to take a look at #17130 (comment) too :)

Thanks, I actually already looked at this recently, but struggled on understanding how the << and >> operators translate to Serialize() and Unserialize() calls. I would have expected corresponding operator<<() and operator>>() methods in the CExt{Pub,Key} classes, but I don't see them -- hence there has to be some implicit magic going on... guess I have to polish up my lousy templates knowledge a bit ;-)