doc: spelling corrections in code comments #17207

pull RandyMcMillan wants to merge 9 commits into bitcoin:master from RandyMcMillan:spelling changing 21 files +99 −105

RandyMcMillan commented at 4:10 PM on October 21, 2019: contributor

fixed minor spelling errors in multiple files

These corrections eliminate spelling error alerts.
fanquake added the label Docs on Oct 21, 2019
practicalswift commented at 4:29 PM on October 21, 2019: contributor

ACK 820778d886c5d7292efb387009f9f151044bfd36

Welcome as a contributor! Good contributor careers typically start out with fixnig spelings :)
in ci/retry/retry:20 in 820778d886 outdated
```
  16 | @@ -17,7 +17,7 @@ __log_out() {
  17 |    echo "$1" 1>&2
  18 |  }
  19 |  
  20 | -# Paramters: max_tries min_sleep max_sleep constant_sleep fail_script EXECUTION_COMMAND
  21 | +# Parameters: max_tries min_sleep max_sleep constant_sleep fail_script EXECUTION_COMMAND
```
fanquake commented at 4:31 PM on October 21, 2019:

This is an upstream file, please don't modify it.

practicalswift commented at 5:30 PM on October 21, 2019:

Are we really expecting to sync this file with the upstream? Seems like a pretty trivial script and it hasn't been updated for two years in the upstream repo. I suggest we treat it as an ordinary in-repo shell script :)

fanquake commented at 5:35 PM on October 21, 2019:

Upstream was updated <2 months ago. If we're going to fix the typos in this file, then we should at least fix all of them so that we only have to do this once.

practicalswift commented at 5:42 PM on October 21, 2019:

Oh, I misread "2 months" as "2 years". Sorry: upstream seems to be alive :)

practicalswift commented at 6:38 PM on October 21, 2019:

@RandyMcMillan Would you mind reporting the retry typo upstream to https://github.com/kadwanev/retry? :)

RandyMcMillan commented at 8:02 PM on October 21, 2019:

Thanks for the feedback.
RandyMcMillan closed this on Oct 21, 2019
RandyMcMillan deleted the branch on Oct 21, 2019
RandyMcMillan restored the branch on Oct 21, 2019
RandyMcMillan commented at 8:17 PM on October 21, 2019: contributor

It appears to have been corrected by @fanquake app stream. https://github.com/kadwanev/retry/commit/0b65e6b7f54ed36b492910470157e180bbcc3c84 @practicalswift - thanks for the vote of confidence. Getting familiar with the code base is tedious. My main focus is the macOS deployment.
RandyMcMillan reopened this on Oct 21, 2019
practicalswift commented at 10:17 PM on October 21, 2019: contributor

@RandyMcMillan I think you accidentally pulled in some unrelated non-typo changes in your latest change :)
DrahtBot commented at 10:27 PM on October 21, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16519 (guix: Change manifest to use channels and inferiors by dongcarl)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
wallet: Avoid showing GUI popups on RPC errors 9712d87610
doc:spelling correction in modifiedcontrib/guix/manifest.scm eed88fc979
doc:spelling correction in src/netbase.cpp 152eed11e6
doc:spelling correction in src/netbase.cpp 75b0d5aa96
doc:spelling correction in src/node/transaction.cpp 3751abb773
doc:spelling correction in src/qt/bitcoin.cpp 4234a7e9e3
doc:spelling correction in src/rpc/rawtransaction.cpp 583e47b02b
doc:spelling correction in src/rpc/rawtransaction_util.h bbb0face63
doc:spelling correction in src/validation.cpp 2b8d1eb69f
RandyMcMillan closed this on Oct 22, 2019
RandyMcMillan deleted the branch on Oct 22, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17214 build: update retry to current version

doc: spelling corrections in code comments #17207

Conflicts