gui: Add Windows taskbar progress

luke-jr commented at 10:32 pm on October 21, 2019: member

Rebase of #14137 Closes: #14134

fanquake added the label GUI on Oct 21, 2019

fanquake added the label Windows on Oct 21, 2019

luke-jr force-pushed on Oct 22, 2019

DrahtBot commented at 2:18 am on October 22, 2019: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17740 (build: remove configure checks for win libraries we don’t link against by fanquake)
#16883 (WIP: Qt: add QML based mobile GUI by icota)
#15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
#14920 (Build: enable -Wdocumentation via isystem by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj commented at 11:11 am on October 22, 2019: member

Concept ACK

laanwj added the label Feature on Oct 22, 2019

laanwj added the label Needs gitian build on Oct 23, 2019

in src/qt/bitcoingui.cpp:973 in 4936a6beba outdated

968@@ -964,6 +969,11 @@ void BitcoinGUI::setNumBlocks(int count, const QDateTime& blockDate, double nVer
969 
970     tooltip = tr("Processed %n block(s) of transaction history.", "", count);
971 
972+#ifdef Q_OS_WIN
973+    m_taskbar_button->setWindow(windowHandle());

laanwj commented at 11:10 am on October 23, 2019:

I don’t think this is the place to do setWindow, every time setNumBlocks is called, move it to the initialization maybe?

luke-jr commented at 6:47 pm on October 23, 2019:

Dunno, this apparently works as-is at least.

(I don’t run Windows, so any major changes might be better off with someone else taking over the PR.)

DrahtBot removed the label Needs gitian build on Oct 24, 2019

laanwj commented at 11:16 am on October 27, 2019: member

it fails the Travis compile:

 0compiling qwinjumplist.cpp
 1
 2compiling qwinthumbnailtoolbar.cpp
 3
 4compiling .moc/release/moc_qwintaskbarprogress.cpp
 5
 6compiling .moc/release/moc_qwinthumbnailtoolbutton.cpp
 7
 8compiling qwintaskbarbutton.cpp
 9
10qwinjumplist.cpp: In function ‘QString createArguments(const QStringList&)’:
11
12qwinjumplist.cpp:99:66: error: invalid use of incomplete type ‘class QRegularExpression’
13
14         tmp.replace(QRegularExpression(QLatin1String("(\\\\*)\"")), QLatin1String("\\1\\1\\\""));
15
16                                                                  ^
17
18In file included from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/qstring.h:1:0,
19
20                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/../../src/corelib/kernel/qobject.h:47,
21
22                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/qobject.h:1,
23
24                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/../../src/corelib/animation/qabstractanimation.h:43,
25
26                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/qabstractanimation.h:1,
27
28                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/QtCore:5,
29
30                 from ../../include/QtWinExtras/QtWinExtrasDepends:3:
31
32/home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/../../src/corelib/tools/qstring.h:80:7: note: forward declaration of ‘class QRegularExpression’
33
34 class QRegularExpression;
35
36       ^~~~~~~~~~~~~~~~~~

Looks like you’re going to have to enable the regular expressions module for this…

luke-jr commented at 1:26 pm on October 27, 2019: member

Or disable qwinjumplist, which this doesn’t even use.

luke-jr commented at 1:32 pm on October 27, 2019: member

I don’t understand why gitian succeeds, but not Travis…

MarcoFalke commented at 1:52 pm on October 27, 2019: member

Gitian fails for the same reason

MarcoFalke added the label Needs gitian build on Oct 27, 2019

luke-jr commented at 5:54 pm on October 27, 2019: member

Ah, saw win32 builds above, but missed that it was just master…

luke-jr force-pushed on Oct 28, 2019

luke-jr commented at 0:19 am on October 28, 2019: member

For now, sed’d out the qwinjumplist stuff since it’s completely unused.

gui: Add Windows taskbar progress a932d13283

luke-jr force-pushed on Oct 28, 2019

DrahtBot removed the label Needs gitian build on Oct 28, 2019

MarcoFalke added the label Needs gitian build on Oct 28, 2019

DrahtBot removed the label Needs gitian build on Oct 28, 2019

luke-jr commented at 0:08 am on October 29, 2019: member

@DrahtBot What’s the point of the side-by-side when they’re not the same on each side?

And why did the last build not even attempt?

MarcoFalke deleted a comment on Oct 29, 2019

MarcoFalke added the label Needs gitian build on Oct 29, 2019

MarcoFalke deleted a comment on Oct 29, 2019

DrahtBot commented at 11:46 am on October 30, 2019: member

Gitian builds

File	commit 6a97e8a060f7632bbaee27d3de8035dc6ebe3895 (master)	commit 5d1962100da67257da5fc00b29825c0ccae0cfd6 (master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`5c2038572887ff66...`	`bb1dc8c999b76fde...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`49ff162cec697356...`	`cfa64b8461042810...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`bf5d5326ce1728d7...`	`5f13b49a9def1c7f...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`3f99ab4bd36646d8...`	`a6d72caa9c1f3fc3...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`974681b2edd08059...`	`b51441d7c48fe639...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`3ed00c6bc92fae48...`	`5cc7160ccd8c73ef...`
bitcoin-0.19.99-osx-unsigned.dmg	`b29d0f99f1ac90fb...`	`f40205af4255c76c...`
bitcoin-0.19.99-osx64.tar.gz	`6629eda6528a0119...`	`761c91aa042310d6...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`4dd3873e05461e09...`	`720d51d999b271d1...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`030765a62624bf71...`	`2f52674e060554fa...`
bitcoin-0.19.99-win64-debug.zip	`ab2432399bb456e4...`	`63010ef28bbe0747...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`d02c501496a8b7f2...`	`9f6b0cc2b7a01052...`
bitcoin-0.19.99-win64.zip	`a5fb8508007170a7...`	`b808b6fda2fdcf4b...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`f5ee1164ab6a761b...`	`a4bb5dc4eaf375f8...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`84e4b287e5cacc9c...`	`90f4370e8c675302...`
bitcoin-0.19.99.tar.gz	`c57314f1b9f55435...`	`1da6f333330365f7...`
bitcoin-core-linux-0.20-res.yml	`05e1dbc1920ed5d7...`	`762aa0525ed705cc...`
bitcoin-core-osx-0.20-res.yml	`cbe866cb3ba41569...`	`a08562a88c403425...`
bitcoin-core-win-0.20-res.yml	`01dad4120e3d63ee...`	`737631691e50525c...`
linux-build.log	`3889b7f85e54145f...`	`81e135693a420bab...`
osx-build.log	`5d9969211f8c99f3...`	`bd4e838e8410d388...`
win-build.log	`097a984b037bd1d1...`	`6b98c2ce1fc2aff3...`
bitcoin-core-linux-0.20-res.yml.diff		`a4b8f6b9f8401f87...`
bitcoin-core-osx-0.20-res.yml.diff		`6b52537b10d571a6...`
bitcoin-core-win-0.20-res.yml.diff		`753e95e370c32e48...`
linux-build.log.diff		`7040af6d72191777...`
osx-build.log.diff		`dcb46da0249c1203...`
win-build.log.diff		`e3df2bc12e188d74...`

DrahtBot removed the label Needs gitian build on Oct 30, 2019

MarcoFalke commented at 12:30 pm on October 30, 2019: member

@luke-jr How about that table? It might be more readable

luke-jr commented at 2:35 pm on October 30, 2019: member

Looks much nicer. Might make the .diffs two-column (if markdown supports it)

jonasschnelli commented at 7:33 pm on November 4, 2019: contributor

Concept ACK Too bad this requires new dependencies and a bunch of ifdefs

in configure.ac:499 in a932d13283

495@@ -496,6 +496,7 @@ case $host in
496      AC_CHECK_LIB([shlwapi],      [main],, AC_MSG_ERROR(libshlwapi missing))
497      AC_CHECK_LIB([iphlpapi],      [main],, AC_MSG_ERROR(libiphlpapi missing))
498      AC_CHECK_LIB([crypt32],      [main],, AC_MSG_ERROR(libcrypt32 missing))
499+     AC_CHECK_LIB([dwmapi],      [main],, AC_MSG_ERROR(libdwmapi missing))

laanwj commented at 2:06 pm on November 6, 2019:

Do you know what is the first release of windows to have dwmapi? Is this a recent addition? (if it’s windows 7 or older it’s fine)

luke-jr commented at 4:32 pm on November 6, 2019:

https://docs.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmsetwindowattribute suggests at least Vista has it.

DrahtBot commented at 8:42 am on January 24, 2020: member

DrahtBot added the label Needs rebase on Jan 24, 2020

fanquake commented at 1:08 am on February 26, 2020: member

Concept ~0. I’ve closed my original issue (#14134), and don’t really think that this change and the additional dependencies is really worthwhile.

luke-jr commented at 3:00 am on February 26, 2020: member

Closing due to lack of interest

luke-jr closed this on Feb 26, 2020

DrahtBot locked this on Feb 15, 2022

gui: Add Windows taskbar progress #17213

Conflicts

Gitian builds