doc: Changed miniupnp links to https #17239

pull sandakersmann wants to merge 1 commits into bitcoin:master from sandakersmann:patch-1 changing 1 files +2 −2

sandakersmann commented at 12:57 PM on October 24, 2019: contributor

doc: Changed miniupnp links to https
doc: Changed miniupnp links to https
doc: Changed miniupnp links to https
6f6852335f
fanquake added the label Docs on Oct 24, 2019
sandakersmann commented at 12:59 PM on October 24, 2019: contributor

This is a new attempt on this PR:

https://github.com/bitcoin/bitcoin/pull/17166

in doc/build-unix.md:166 in 6f6852335f

 162 | @@ -163,8 +163,8 @@ symbols, which reduces the executable size by about 90%.
 163 |  miniupnpc
 164 |  ---------
 165 |  
 166 | -[miniupnpc](http://miniupnp.free.fr/) may be used for UPnP port mapping.  It can be downloaded from [here](
 167 | -http://miniupnp.tuxfamily.org/files/).  UPnP support is compiled in and
 168 | +[miniupnpc](https://miniupnp.tuxfamily.org) may be used for UPnP port mapping.  It can be downloaded from [here](

fjahr commented at 2:23 PM on October 24, 2019:

Could also fix double white spaces between the sentences while you are at it :)

fanquake commented at 3:12 PM on October 24, 2019:

The white space hasn't changed with this PR, and doesn't really need fixing either. I'm just going to merge this, because it's already been bike-shed to death.

fjahr commented at 2:26 PM on October 24, 2019: member

ACK 6f68523

Just see my nit about the white space. Have you looked if you can pack a little more into this PR? If you grep for other http:// links that could be updated to https:// that could turn up some other fixed to be included here.
fjahr approved
fanquake commented at 3:14 PM on October 24, 2019: member

ACK 6f6852335fc236dd6ec161162f49bfd813036acc - as mentioned in this comment, in future, there's no need to open a new PR instead than squashing. One of the requirements of contributing to Bitcoin Core is some basic git usage, and we have some documentation on that in our CONTRIBUTING.md (which also mentions not to open multiple PRs).
fanquake referenced this in commit d7134ead84 on Oct 24, 2019
fanquake merged this on Oct 24, 2019
fanquake closed this on Oct 24, 2019
instagibbs commented at 3:57 PM on October 24, 2019: member

@sandakersmann if you have git-related questions, feel free to jump on freenode #bitcoin-core-dev and ping me there (instagibbs)
jasonbcox referenced this in commit f59c11d8db on Oct 30, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels