nsis: Write to correct filename in first place #17308

pull dongcarl wants to merge 1 commits into bitcoin:master from dongcarl:2019-10-simplify-nsis-exe-rename changing 2 files +2 −5

dongcarl commented at 8:49 PM on October 29, 2019: member

Per MarcoFalke's suggestion here #17029 (review)
nsis: Write to correct filename in first place 3b3b93174a
dongcarl added the label Build system on Oct 29, 2019
dongcarl added the label Needs gitian build on Oct 29, 2019
fanquake commented at 9:40 PM on October 29, 2019: member

Concept ACK
MarcoFalke commented at 12:55 AM on October 30, 2019: member

unsigned ACK 3b3b93174a216961f935b63b03732fbc2821ff92, makes sense to name it that way because it will raise the "unsinged" error in Windows
laanwj commented at 11:31 AM on October 30, 2019: member

ACK if it passes travis/gitian build.

DrahtBot commented at 5:31 AM on October 31, 2019: member

Gitian builds

File	commit edd9d0781b96e71f88bd87b30dd10ad008b964a5 (master)	commit 549720c7ccfd829ed917ce5b66fb6b44fa5b4cd8 (master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`aa5c6407b8b7c400...`	`fb93e7a40fdf6c89...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`22d82c4262361628...`	`3d3dc39798320894...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`3d7628fcfe2459c3...`	`1347e43c2c1fc5ef...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`11c14c5d33140142...`	`3afd95c8a51e2f5d...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`40261b5ef572574d...`	`0fd251c899700d2d...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`5174e7b159756111...`	`1dd0d43dac441747...`
bitcoin-0.19.99-osx-unsigned.dmg	`4df6668f2adbaa64...`	`6f6d853e3f759492...`
bitcoin-0.19.99-osx64.tar.gz	`4269dd52a2395a15...`	`1d78d7de666f0729...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`708e0ee44266756c...`	`6a4a47528726a7d2...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`c19c55e0a0dcde8c...`	`e4507e34e96d165d...`
bitcoin-0.19.99-win64-debug.zip	`0a58641e721251ef...`	`588ee9429861f5e8...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`3c3297e4adc8f86e...`	`d293d161fb743160...`
bitcoin-0.19.99-win64.zip	`ff2f6875764da40f...`	`d95f2dfe3ee1ed8b...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`24f714613fa2858c...`	`1426b629f5df5f8a...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`712c063f98d8091e...`	`fe6a9a1719256912...`
bitcoin-0.19.99.tar.gz	`0c6f7a02b297fc15...`	`d9d6dcf8ac25ae27...`
bitcoin-core-linux-0.20-res.yml	`2a9301d7c3558a07...`	`5dfec7aedddae11b...`
bitcoin-core-osx-0.20-res.yml	`af49204ee36ffb93...`	`0919d67609a4b687...`
bitcoin-core-win-0.20-res.yml	`4d8986c8867a3420...`	`80901b368e4f483b...`
linux-build.log	`807dfd244d78094a...`	`b31dbcbd9488ada1...`
osx-build.log	`5e16316a82405d4b...`	`79d8dab721a41e91...`
win-build.log	`2b0025ddf706198a...`	`f738dd35212487d9...`
bitcoin-core-linux-0.20-res.yml.diff		`a902602e0b4eaacc...`
bitcoin-core-osx-0.20-res.yml.diff		`32d52173f78f316f...`
bitcoin-core-win-0.20-res.yml.diff		`abb974f357e26e59...`
linux-build.log.diff		`5550da0277e627bf...`
osx-build.log.diff		`86a60c3c23f0a1eb...`
win-build.log.diff		`f9a18f9317d8c184...`

DrahtBot removed the label Needs gitian build on Oct 31, 2019
laanwj referenced this in commit feb1a8c03a on Oct 31, 2019
laanwj merged this on Oct 31, 2019
laanwj closed this on Oct 31, 2019
sidhujag referenced this in commit 23d6ae497c on Oct 31, 2019
MarkLTZ referenced this in commit d62da90db5 on Apr 19, 2020
MarkLTZ referenced this in commit 1582586db3 on Apr 19, 2020
sidhujag referenced this in commit 286414d811 on Nov 10, 2020
random-zebra referenced this in commit 3614de632e on Jul 19, 2021
UdjinM6 referenced this in commit 60c1238ad7 on Oct 23, 2021
UdjinM6 referenced this in commit 8d1b4b7832 on Oct 23, 2021
UdjinM6 referenced this in commit 824d6c08f9 on Dec 4, 2021
UdjinM6 referenced this in commit 632c759352 on Dec 5, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17029 gitian: Various improvements for Windows descriptor