refactor: Replace all uses of boost::optional with our own Optional type #17316

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2019_10_optional changing 5 files +14 −14

laanwj commented at 1:29 PM on October 30, 2019: member
Replace all uses of boost::optional with our own Optional type. Luckily, there aren't so many.

After this:
- boost::optional is no longer used directly (only through Optional which is an alias for it)
- boost/optional.hpp is only included in one place

refactor: Replace all uses of boost::optional with our own Optional type

After this:

- `boost::optional` is no longer used directly (only through `Optional`
    which is an alias for it)
- `boost/optional.hpp` is only included in one place

d314e8a818

laanwj added the label Utils/log/libs on Oct 30, 2019
fanquake added this to the "In progress" column in a project

MarcoFalke commented at 1:32 PM on October 30, 2019: member

ACK d314e8a818d4c162b1c7201533e6b600dcab2d91
MarcoFalke commented at 1:33 PM on October 30, 2019: member

boost/optional.hpp is only included in one place

Unfortunately in the header, so it is indirectly included everywhere. Though, I don't think there is a way to not put it in the header.
laanwj commented at 1:45 PM on October 30, 2019: member

Unfortunately in the header, so it is indirectly included everywhere.

True. I meant directly. This similar as for the fs abstraction.

Though, I don't think there is a way to not put it in the header.

As this is essentially a header-only type, only implementing it ourselves would avoid that. But doing that would be dragging water to the sea with #16684 coming up.
practicalswift commented at 2:07 PM on October 30, 2019: contributor

ACK d314e8a818d4c162b1c7201533e6b600dcab2d91 -- diff looks correct + satisfying to see incremental progress towards the goal of a Boost free future :)
DrahtBot commented at 5:38 PM on October 30, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16463 ([BIP 174] Implement serialization support for GLOBAL_XPUB field. by achow101)
- #16377 ([rpc] don't automatically append inputs in walletcreatefundedpsbt & fundrawtransaction by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
jtimon commented at 5:47 PM on October 30, 2019: contributor

ACK d314e8a818d4c162b1c7201533e6b600dcab2d91 I didn't test, but this seems obviously correct.
fanquake approved
fanquake commented at 6:19 PM on October 30, 2019: member

ACK d314e8a818d4c162b1c7201533e6b600dcab2d91
fanquake referenced this in commit 08e2947312 on Oct 30, 2019
fanquake merged this on Oct 30, 2019
fanquake closed this on Oct 30, 2019
sidhujag referenced this in commit 39aee4b441 on Oct 31, 2019
jnewbery moved this from the "In progress" to the "Done" column in a project

jasonbcox referenced this in commit dcc5070fc1 on Sep 8, 2020
sidhujag referenced this in commit 80506c08ad on Nov 10, 2020
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

refactor: Replace all uses of boost::optional with our own Optional type #17316

Conflicts