Add Boost::Process to AppVeyor dependencies #17412

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2019/11/msvc_boost_process changing 2 files +2 −2

Sjors commented at 8:24 AM on November 8, 2019: member

Currently unused, but it's included with Boost by default on other operating systems.

This prevents the open PR #15382 (and everything on top of it) from invalidating the globally shared AppVeyor cache at every update, or from failing due cache not getting invalidated: #15382 (comment)
laanwj added the label Tests on Nov 8, 2019
promag commented at 8:40 AM on November 8, 2019: member

@laanwj test label?

Concept ACK.

[build] add boost::process to AppVeyor dependencies

Currently unused, but it's included with Boost by default on other
operating systems. This prevents the open PR #15382 from invalidating
the globally shared AppVeyor cache at every update.

3c5e30b959

in .appveyor.yml:10 in d5faf21e72 outdated

   6 | @@ -7,7 +7,7 @@ clone_depth: 5
   7 |  environment:
   8 |    APPVEYOR_SAVE_CACHE_ON_ERROR: true
   9 |    CLCACHE_SERVER: 1
  10 | -  PACKAGES: berkeleydb boost-filesystem boost-multi-index boost-signals2 boost-test boost-thread libevent openssl rapidcheck zeromq double-conversion
  11 | +  PACKAGES: berkeleydb boost-filesystem boost-proces boost-multi-index boost-signals2 boost-test boost-thread libevent openssl rapidcheck zeromq double-conversion

practicalswift commented at 9:41 AM on November 8, 2019:

boost-proces should be boost-process? :)

Sjors commented at 10:45 AM on November 8, 2019:

Thanks, fixed.

Sjors force-pushed on Nov 8, 2019
fanquake commented at 2:21 PM on November 8, 2019: member

I'm going to close this in favour of #17416, which seems like the better solution. I also don't like the idea of preemptively adding dependencies and changing build instructions before the PR that actually requires it.
fanquake closed this on Nov 8, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#15382 util: add RunCommandParseJSON