zmq: Fix due to invalid argument and multiple notifiers #17445

1. 
   promag commented at 10:28 PM on November 11, 2019: member

   ZMQ initialization is interrupted if any notifier fails, and in that case all notifiers are destroyed. The notifier shutdown assumes that the initialization had occurred. This is not valid when there are multiple notifiers and any except the last fails to initialize.

   Can be tested by running test/functional/interface_zmq.py from this branch with bitcoind from master.

   Closes #17185.

2. zmq: Fix due to invalid argument and multiple notifiers 3e730bf90a
3. 
   promag commented at 10:37 PM on November 11, 2019: member

   Does this needs backport?

4. fanquake added the label RPC/REST/ZMQ on Nov 11, 2019
5. laanwj added the label Needs backport (0.19) on Nov 12, 2019
6. 
   laanwj commented at 11:02 AM on November 12, 2019: member

   Code review ACK 3e730bf90aaf53c41ff3a778f6aac15d163d1c0c, thanks for adding a test

   Does this needs backport?

   I guess we could include it in 0.19.1.

7. laanwj added this to the milestone 0.19.1 on Nov 12, 2019
8. 
   laanwj commented at 12:37 PM on November 12, 2019: member

   This gets rid of the crash, but looking at the log in #17185#issue-508897881 , doesn't this mean bitcoind will no longer stop on zmq argument/binding errors at all, nor even report them (because that requires a debug option)? That should probably be fixed too, though not necessarily here.

9. 
   promag commented at 12:42 PM on November 12, 2019: member

   Yeah I forgot to mention that. And I agree it should be done in other PR because maybe it can't be backport.

   What I could change here is to give a good warning on zmq failure?

10. promag referenced this in commit c351f876e2 on Dec 23, 2019
11. laanwj referenced this in commit 295211e668 on Jan 8, 2020
12. laanwj merged this on Jan 8, 2020
13. laanwj closed this on Jan 8, 2020

    ---

14. promag deleted the branch on Jan 8, 2020
15. sidhujag referenced this in commit 313253aa87 on Jan 8, 2020
16. fanquake removed the label Needs backport (0.19) on Jan 9, 2020
17. 
    fanquake commented at 10:47 AM on January 9, 2020: member

    Being backported in 17792.

18. promag referenced this in commit 179d55f052 on Jan 14, 2020
19. laanwj referenced this in commit 98159132c3 on Jan 20, 2020
20. MarkLTZ referenced this in commit d99bc96496 on Feb 13, 2020
21. jasonbcox referenced this in commit 979e8272c7 on Sep 3, 2020
22. sidhujag referenced this in commit c9311433b0 on Nov 10, 2020
23. DrahtBot locked this on Feb 15, 2022

Milestone
0.19.1