test: update fuzz directory in .gitignore #17452

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:update-fuzz-gitignore changing 1 files +2 −1

jonatack commented at 1:39 PM on November 12, 2019: member
The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework.

This commit:
- removes src/test/test_bitcoin_fuzzy which is no longer used in favor of src/test/fuzz
- ignores the src/test/fuzz directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files.
Co-authored-by: Karl-Johan Alm karljohan-alm@garage.co.jp
in .gitignore:10 in ba76e3c5f4 outdated
```
   6 | @@ -7,8 +7,8 @@ src/bitcoind
   7 |  src/bitcoin-cli
   8 |  src/bitcoin-tx
   9 |  src/bitcoin-wallet
  10 | +src/test/fuzz
```
MarcoFalke commented at 2:08 PM on November 12, 2019:

This is a folder, as opposed to the src/test/test_bitcoin_fuzzy binary.

I am not sure if the whole folder should be excluded. Also I am not sure if it makes sense to enumerate all binaries one-by-one.

No strong opinion, though. I don't really care about gitignore.

laanwj commented at 1:30 PM on November 18, 2019:

No strong opinion, though. I don't really care about gitignore.

Out-of-tree builds ftw.

But I think as long as we're enumerating binaries here, we should add them all. Ignoring the entire directory is a bad idea because it will also ignore new source files.

kallewoof commented at 9:26 AM on January 3, 2020:

Suggest adding !src/test/fuzz/*.* below this line to re-watch anything with an extension. This on its own would start ignoring even .cpp/.h files in that folder.

jonatack commented at 9:27 AM on January 3, 2020:

Agreed! I was hesitant between just removing src/test/test_bitcoin_fuzzy or adding the unignore.

jonatack commented at 9:29 AM on January 3, 2020:

I'll pull your commit into this PR.
DrahtBot commented at 2:27 PM on November 12, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16834 (Fetch Headers over DNS by TheBlueMatt)
- #16762 (Rust-based Backup over-REST block downloader by TheBlueMatt)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
laanwj added the label Tests on Nov 29, 2019
MarcoFalke added the label Waiting for author on Dec 22, 2019
kallewoof commented at 9:28 AM on January 3, 2020: member

Concept ACK. The git status clutter is annoying.
MarcoFalke renamed this:
~~lib: update fuzz directory in .gitignore~~
test: update fuzz directory in .gitignore
on Jan 3, 2020

gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy

The fuzzing gitignores haven't been updated since a4153e2
in 2016 that added an initial simple fuzzing framework.

This commit:

- removes `src/test/test_bitcoin_fuzzy` which is no longer
  used in favor of `src/test/fuzz`

- ignores the src/test/fuzz directory, then un-ignores any
  files in it with an extension

Co-authored-by: Karl-Johan Alm <karljohan-alm@garage.co.jp>

77ef48d532

jonatack force-pushed on Jan 3, 2020
jonatack commented at 1:34 PM on January 3, 2020: member

@kallewoof LMK if the GitHub email isn't your current one in order to be credited properly; I found it in the git history.
kallewoof commented at 1:40 PM on January 3, 2020: member

@kallewoof LMK if the GitHub email isn't your current one in order to be credited properly; I found it in the git history.

Looks good :)
fanquake removed the label Waiting for author on Jan 4, 2020
fanquake commented at 9:00 AM on January 4, 2020: member

@MarcoFalke or @practicalswift can either of you comment/ACK in regards to fuzzing ignoring completeness.
MarcoFalke commented at 7:42 PM on January 7, 2020: member

ACK 77ef48d53263deaf89290c1cbadb6d90e688575d
practicalswift commented at 9:26 PM on January 7, 2020: contributor

ACK 77ef48d53263deaf89290c1cbadb6d90e688575d @fanquake Sorry for replying late :)
fanquake referenced this in commit fcef6dbc15 on Jan 7, 2020
fanquake merged this on Jan 7, 2020
fanquake closed this on Jan 7, 2020
sidhujag referenced this in commit b3cd6c30e2 on Jan 8, 2020
jonatack deleted the branch on Jul 27, 2020
sidhujag referenced this in commit 3a759cc764 on Nov 10, 2020
kittywhiskers referenced this in commit 8f47c82c3c on Aug 2, 2021
kittywhiskers referenced this in commit ac09366d57 on Aug 5, 2021
kittywhiskers referenced this in commit d4a04366c1 on Aug 5, 2021
PastaPastaPasta referenced this in commit 09ae68e4a6 on Aug 6, 2021
kittywhiskers referenced this in commit 5f69fac763 on Aug 8, 2021
kittywhiskers referenced this in commit 6d349e164b on Aug 11, 2021
PastaPastaPasta referenced this in commit 90e7119a8b on Aug 11, 2021
5tefan referenced this in commit 2d1f29aede on Aug 12, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

test: update fuzz directory in .gitignore #17452

Conflicts