ci: Add valgrind run #17490

pull MarcoFalke wants to merge 0 commits into bitcoin:master from MarcoFalke:1911-ciValgrind changing 0 files +0 −0

MarcoFalke commented at 8:13 PM on November 15, 2019: member

Fixes #17460
fanquake added the label Tests on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
MarcoFalke force-pushed on Nov 15, 2019
practicalswift commented at 7:10 PM on November 17, 2019: contributor

ACK fae4117ddeb5c2264f4d2b1cfcb436b68bd38e86

This has been needed for a very long time! Thanks for adding! :)

Could you do a test run in Travis in another branch where you introduce an intentional uninitialised read to verify that it is caught?
laanwj commented at 1:15 PM on November 18, 2019: member

ACK fae4117ddeb5c2264f4d2b1cfcb436b68bd38e86

(agree it would be nice to see a failing run as @practicalswift mentions)

in ci/test/00_setup_env_native_valgrind.sh:9 in fae4117dde outdated

   0 | @@ -0,0 +1,14 @@
   1 | +#!/usr/bin/env bash
   2 | +#
   3 | +# Copyright (c) 2019 The Bitcoin Core developers
   4 | +# Distributed under the MIT software license, see the accompanying
   5 | +# file COPYING or http://www.opensource.org/licenses/mit-license.php.
   6 | +
   7 | +export LC_ALL=C.UTF-8
   8 | +
   9 | +export PACKAGES="valgrind clang llvm python3-zmq libssl1.0-dev libevent-dev bsdmainutils libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev libdb5.3++-dev libminiupnpc-dev libzmq3-dev"

MarcoFalke commented at 1:58 PM on November 19, 2019:

export PACKAGES="valgrind clang llvm python3-zmq libevent-dev bsdmainutils libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev libdb5.3++-dev libminiupnpc-dev libzmq3-dev"

fanquake added the label Waiting for author on Nov 19, 2019
DrahtBot commented at 6:26 AM on November 22, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17399 (validation: Templatize ValidationState instead of subclassing by jkczyz)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
elichai commented at 2:38 PM on November 25, 2019: contributor

I don't see any valgrind output except for the benchmarks https://travis-ci.org/bitcoin/bitcoin/jobs/612624502#L2889
MarcoFalke commented at 3:43 PM on November 25, 2019: member

For the unit tests, it will only be printed on failure
DrahtBot added the label Needs rebase on Dec 7, 2019
MarcoFalke removed the label Waiting for author on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
DrahtBot removed the label Needs rebase on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
MarcoFalke force-pushed on Dec 10, 2019
MarcoFalke force-pushed on Dec 11, 2019
MarcoFalke force-pushed on Dec 11, 2019
MarcoFalke force-pushed on Dec 11, 2019
MarcoFalke commented at 4:07 AM on December 11, 2019: member

Added a failing travis as requested by @practicalswift and @laanwj

I will remove the failing commit after review, but before merge.
practicalswift commented at 7:14 AM on December 11, 2019: contributor

ACK facb416ad5ba47b01ee52c273a5c5e3709f06f07 -- diff looks correct
MarcoFalke commented at 2:58 PM on December 11, 2019: member

The failing travis build was https://travis-ci.org/bitcoin/bitcoin/builds/623456054

Will reset the branch now
MarcoFalke closed this on Dec 11, 2019
MarcoFalke force-pushed on Dec 11, 2019
MarcoFalke commented at 2:59 PM on December 11, 2019: member

oops, wrong force push
MarcoFalke commented at 2:59 PM on December 11, 2019: member

test
MarcoFalke commented at 3:00 PM on December 11, 2019: member

test2
MarcoFalke commented at 3:02 PM on December 11, 2019: member

:weary: See #17725
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17460 Run tests in memory sanitizer

ci: Add valgrind run #17490

Conflicts