ci: Add valgrind run #17725

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1911-ciValgrind changing 6 files +123 −6

MarcoFalke commented at 3:01 PM on December 11, 2019: member

Fixes #17460
ci: Add valgrind run facb416ad5
fanquake added the label Tests on Dec 11, 2019
MarcoFalke commented at 3:03 PM on December 11, 2019: member

A failing travis build was https://travis-ci.org/bitcoin/bitcoin/builds/623456054
in ci/test/00_setup_env_native_valgrind.sh:15 in facb416ad5
```
  10 | +export USE_VALGRIND=1
  11 | +export NO_DEPENDS=1
  12 | +export TEST_RUNNER_EXTRA="p2p_segwit.py"  # Only run one test for now. TODO enable all and bump timeouts
  13 | +export RUN_FUNCTIONAL_TESTS=true
  14 | +export GOAL="install"
  15 | +export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang CXX=clang++"  # TODO enable GUI
```
EthanHeilman commented at 4:04 PM on December 11, 2019:

Should we be testing with this flag --with-incompatible-bdb set to true? Is there are reason that we can't use the correct version of berkleydb here?

MarcoFalke commented at 6:01 PM on December 11, 2019:

We can use the bdb package from depends or from the Ubuntu package manager. The package manager doesn't come with the bdb version we want, so --with-incompatible-bdb is needed. Switching to ./depends is possible, but shouldn't matter, as we ignore leaks and memory issues in dependencies anyway. They need to be dealt with upstream.
DrahtBot commented at 5:28 PM on December 11, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #12134 (Build previous releases and run functional tests by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 6:21 PM on December 16, 2019: member

Anything left to do here?
practicalswift commented at 10:35 PM on December 16, 2019: contributor

ACK facb416ad5ba47b01ee52c273a5c5e3709f06f07

Very nice!
instagibbs commented at 3:30 PM on December 17, 2019: member

concept ACK!
MarcoFalke referenced this in commit 890eac8f82 on Dec 17, 2019
MarcoFalke merged this on Dec 17, 2019
MarcoFalke closed this on Dec 17, 2019
MarcoFalke deleted the branch on Dec 17, 2019
sidhujag referenced this in commit 15711eb917 on Dec 17, 2019
sidhujag referenced this in commit b9e29f9e9c on Nov 10, 2020
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17460 Run tests in memory sanitizer

ci: Add valgrind run #17725

Conflicts