util: remove unwanted fields from bitcoin-cli -getinfo #17650

pull malevolent wants to merge 1 commits into bitcoin:master from malevolent:rethink_bitcoin_cli changing 2 files +0 −6
  1. malevolent commented at 9:40 AM on December 2, 2019: contributor

    Removed the following fields from -getinfo: protocolversion, walletversion and keypoololdest.

  2. malevolent renamed this:
    Removed unwanted fields from -getinfo. Closes #17314
    Removed unwanted fields from -getinfo.
    on Dec 2, 2019
  3. laanwj commented at 10:30 AM on December 2, 2019: member

    Concept ACK

    Code changes look good to me. Some git nits:

    • Please adapt your commit message to the standard format: a short title, an empty line then the body of the text
    • Please set a username and mail address other than "EC2 Default User"
  4. practicalswift commented at 10:39 AM on December 2, 2019: contributor

    Concept ACK @malevolent Welcome as a contributor! :)

  5. fanquake added the label Utils/log/libs on Dec 2, 2019
  6. fanquake added the label Waiting for author on Dec 2, 2019
  7. emilengler commented at 4:26 PM on December 2, 2019: contributor

    Concept ACK

    Your tests are failing. Please update test/functional/interface_bitcoin_cli.py See line 61-76

  8. malevolent commented at 12:40 AM on December 3, 2019: contributor

    @laanwj Yes sir, done and done. @practicalswift Thank you :) @emilengler Thanks, just pushed change to delete tests for removed api calls.

  9. fanquake renamed this:
    Removed unwanted fields from -getinfo.
    util: remove unwanted fields from bitcoin-cli -getinfo
    on Dec 3, 2019
  10. fanquake commented at 12:44 AM on December 3, 2019: member

    Please squash your commits.

    Please adapt your commit message to the standard format: a short title, an empty line then the body of the text

    You could use a commit title like util: remove unwanted fields from bitcoin-cli -getinfo.

  11. malevolent commented at 12:43 PM on December 3, 2019: contributor

    Hi @fanquake , thanks for letting me know, I rebased and used better titles for the commit messages. Please let me know if theres anything else needed

  12. malevolent force-pushed on Dec 3, 2019
  13. practicalswift commented at 1:30 PM on December 3, 2019: contributor

    ACK 868a32228688afca262f10d3be9fa6caa9cdea65 -- diff looks correct

  14. fanquake removed the label Waiting for author on Dec 3, 2019
  15. laanwj commented at 3:21 PM on December 3, 2019: member

    the author is still reported as "EC2 Default User"

    commit 868a32228688afca262f10d3be9fa6caa9cdea65
Author: EC2 Default User <ec2-user@ip-172-31-6-106.us-west-1.compute.internal>

    i think you need to do git commit --amend --reset-author to fix this, if you want to be credited correctly

  16. util: remove unwanted fields from bitcoin-cli -getinfo
    In accordance with #17314, Removing noisy fields from -getinfo. Fields removed: protocolversion, walletversion and keypoololdest. In addition to changing bitcoin-cli -getinfo, there is another change to test/functional/interface_bitcoin_cli.py. This change deletes tests that utilize removed -getinfo calls.
    01c8701559
  17. malevolent force-pushed on Dec 4, 2019
  18. malevolent commented at 6:50 AM on December 4, 2019: contributor

    @laanwj Thanks I think that fixed it, let me know if there is anything else I need to do

  19. laanwj commented at 10:05 AM on December 4, 2019: member

    ACK 01c87015597021bf1c0856f7f6be175bdde844b2

  20. laanwj added the label Needs release note on Dec 4, 2019
  21. practicalswift commented at 10:15 AM on December 4, 2019: contributor

    ACK 01c87015597021bf1c0856f7f6be175bdde844b2 -- diff looks correct

  22. malevolent commented at 7:30 PM on December 4, 2019: contributor

    @laanwj is there anything I need to do for the release note label that was added? Also, I think I should change it from saying "closes #17314" since there are other parts to that issue, right?

  23. fanquake commented at 7:32 PM on December 4, 2019: member

    release note label that was added?

    This can be addressed at a later date.

    I think I should change itfrom saying "closes #17314" since there are other parts to that issue, right?

    Correct, that issue doesn't need to be closed after this is merged.

  24. achow101 commented at 7:55 PM on December 4, 2019: member

    ACK 01c87015597021bf1c0856f7f6be175bdde844b2

  25. fanquake referenced this in commit 5aee0e2163 on Dec 4, 2019
  26. fanquake merged this on Dec 4, 2019
  27. fanquake closed this on Dec 4, 2019
  28. sidhujag referenced this in commit 46154724ed on Dec 4, 2019
  29. laanwj commented at 9:28 AM on December 5, 2019: member

    release note label that was added?

    Yea, it's probably better to wait until the release in this case, if there's other bitcoin-cli changes at well they should be grouped and not scattered over the place.

  30. fanquake commented at 7:31 AM on May 23, 2020: member

    @laanwj Could you add any relevant release notes to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft ?

  32. fanquake removed the label Needs release note on May 23, 2020
  33. deadalnix referenced this in commit e58b64941f on Nov 6, 2020
  34. sidhujag referenced this in commit 0ca1b0213e on Nov 10, 2020
  35. DrahtBot locked this on Feb 15, 2022
Contributors
malevolentlaanwjpracticalswiftemilenglerfanquakeachow101MarcoFalke
Labels
Utils/log/libs
Linked (view graph)
#17314 Re-thinking `bitcoin-cli -getinfo`
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me