util: remove unwanted fields from bitcoin-cli -getinfo #17650

pull malevolent wants to merge 1 commits into bitcoin:master from malevolent:rethink_bitcoin_cli changing 2 files +0 −6

malevolent commented at 9:40 am on December 2, 2019: contributor

Removed the following fields from -getinfo: protocolversion, walletversion and keypoololdest.
malevolent renamed this:
~~Removed unwanted fields from -getinfo. Closes #17314~~
Removed unwanted fields from -getinfo.
on Dec 2, 2019
laanwj commented at 10:30 am on December 2, 2019: member
Concept ACK

Code changes look good to me. Some git nits:
- Please adapt your commit message to the standard format: a short title, an empty line then the body of the text
- Please set a username and mail address other than “EC2 Default User”
practicalswift commented at 10:39 am on December 2, 2019: contributor

Concept ACK @malevolent Welcome as a contributor! :)
fanquake added the label Utils/log/libs on Dec 2, 2019
fanquake added the label Waiting for author on Dec 2, 2019
emilengler commented at 4:26 pm on December 2, 2019: contributor

Concept ACK

Your tests are failing. Please update test/functional/interface_bitcoin_cli.py See line 61-76
malevolent commented at 0:40 am on December 3, 2019: contributor

@laanwj Yes sir, done and done. @practicalswift Thank you :) @emilengler Thanks, just pushed change to delete tests for removed api calls.
fanquake renamed this:
~~Removed unwanted fields from -getinfo.~~
util: remove unwanted fields from bitcoin-cli -getinfo
on Dec 3, 2019
fanquake commented at 0:44 am on December 3, 2019: member

Please squash your commits.

Please adapt your commit message to the standard format: a short title, an empty line then the body of the text

You could use a commit title like util: remove unwanted fields from bitcoin-cli -getinfo.
malevolent commented at 12:43 pm on December 3, 2019: contributor

Hi @fanquake , thanks for letting me know, I rebased and used better titles for the commit messages. Please let me know if theres anything else needed
malevolent force-pushed on Dec 3, 2019
practicalswift commented at 1:30 pm on December 3, 2019: contributor

ACK 868a32228688afca262f10d3be9fa6caa9cdea65 – diff looks correct
fanquake removed the label Waiting for author on Dec 3, 2019
laanwj commented at 3:21 pm on December 3, 2019: member
the author is still reported as “EC2 Default User”
0commit 868a32228688afca262f10d3be9fa6caa9cdea65 1Author: EC2 Default User <ec2-user@ip-172-31-6-106.us-west-1.compute.internal>
i think you need to do git commit --amend --reset-author to fix this, if you want to be credited correctly

util: remove unwanted fields from bitcoin-cli -getinfo

In accordance with #17314, Removing noisy fields from -getinfo. Fields removed: protocolversion, walletversion and keypoololdest. In addition to changing bitcoin-cli -getinfo, there is another change to test/functional/interface_bitcoin_cli.py. This change deletes tests that utilize removed -getinfo calls.

01c8701559

malevolent force-pushed on Dec 4, 2019
malevolent commented at 6:50 am on December 4, 2019: contributor

@laanwj Thanks I think that fixed it, let me know if there is anything else I need to do
laanwj commented at 10:05 am on December 4, 2019: member

ACK 01c87015597021bf1c0856f7f6be175bdde844b2
laanwj added the label Needs release note on Dec 4, 2019
practicalswift commented at 10:15 am on December 4, 2019: contributor

ACK 01c87015597021bf1c0856f7f6be175bdde844b2 – diff looks correct
malevolent commented at 7:30 pm on December 4, 2019: contributor

@laanwj is there anything I need to do for the release note label that was added? Also, I think I should change it from saying “closes #17314” since there are other parts to that issue, right?
fanquake commented at 7:32 pm on December 4, 2019: member

release note label that was added?

This can be addressed at a later date.

I think I should change itfrom saying “closes #17314” since there are other parts to that issue, right?

Correct, that issue doesn’t need to be closed after this is merged.
achow101 commented at 7:55 pm on December 4, 2019: member

ACK 01c87015597021bf1c0856f7f6be175bdde844b2
fanquake referenced this in commit 5aee0e2163 on Dec 4, 2019
fanquake merged this on Dec 4, 2019
fanquake closed this on Dec 4, 2019
sidhujag referenced this in commit 46154724ed on Dec 4, 2019
laanwj commented at 9:28 am on December 5, 2019: member

release note label that was added?

Yea, it’s probably better to wait until the release in this case, if there’s other bitcoin-cli changes at well they should be grouped and not scattered over the place.
fanquake commented at 7:31 am on May 23, 2020: member

@laanwj Could you add any relevant release notes to https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft ?
MarcoFalke commented at 11:32 am on May 23, 2020: member

Done https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.20.0-Release-Notes-Draft/_compare/b03541ec204bd2c7460b3c383c45f84b21c5b65c...3f531649bb00d9824814ff3a7e9c7282e806844b
fanquake removed the label Needs release note on May 23, 2020
deadalnix referenced this in commit e58b64941f on Nov 6, 2020
sidhujag referenced this in commit 0ca1b0213e on Nov 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors
malevolent laanwj practicalswift emilengler fanquake achow101 MarcoFalke

Labels
Utils/log/libs