depends: add ability to skip building qrencode #17658

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends_no_qrencode changing 4 files +14 −2

fanquake commented at 8:18 PM on December 3, 2019: member

Similar to other depends packages, add the ability to skip building qrencode by passing NO_QR=1. Same as #16089.
depends: add ability to skip building qrencode c8becb8280
fanquake added the label Build system on Dec 3, 2019
fanquake added the label Needs gitian build on Dec 3, 2019
laanwj commented at 9:43 AM on December 4, 2019: member

Concept ACK.

NO_BOOST next? :smile:
practicalswift commented at 9:56 AM on December 4, 2019: contributor

Concept ACK

Very nice! NO_QR=1 is what our users expect. Talking about user expectations: note that make depends builds Boost with g++ regardless of CXX for some reason :) See #15914 and #17620 (comment).
laanwj commented at 10:03 AM on December 4, 2019: member

note that make depends builds Boost with g++ regardless of CXX for some reason :)

Likely because boost has its own scrapheap of a build system… this will need a specific change similar to #17466 for Qt. can you please create a new issue for this
practicalswift commented at 10:13 AM on December 4, 2019: contributor

@laanwj Yes, the root cause is likely b2 trying to be "smart" :) There is already the issue #15914 ("make depends" builds boost with g++ regardless of CXX).

DrahtBot commented at 8:25 AM on December 5, 2019: member

Gitian builds

File	commit bce44089db27e2b21a3dc2954b170ecf0d6d998e<br>(master)	commit 21d30854e15b5d52ed80f1e0947bead98114cc51<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`40caf742a2674966...`	`037cfac1d2962c1d...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`34d078b55cc81ffa...`	`1279a2eb08f4c447...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`0e4bfdc2db429350...`	`2ec7ad5fa5871286...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`66f9553d61083c86...`	`1f4dbdb9951e3b09...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`b94d6da73b0724fc...`	`5faf61fb86e6ecb0...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`9a7eb5bfc03dc3c7...`	`a677488ee59be7d6...`
bitcoin-0.19.99-osx-unsigned.dmg	`080fc64ce42ac922...`	`675e7582ae9322bd...`
bitcoin-0.19.99-osx64.tar.gz	`25c44e85f72a9718...`	`a16692a26c10723d...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`ebf248bcad5d1362...`	`36b3ad2a99d2e035...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`90d60c22deb5c3d9...`	`5f882d700743f58a...`
bitcoin-0.19.99-win64-debug.zip	`4b7041137b8551bb...`	`c111d76e43a929a9...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`fafa36315d943962...`	`d7c323629c7c7177...`
bitcoin-0.19.99-win64.zip	`45fd276418a2e762...`	`0da3d57b347d2c5c...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`ad62fd169f3b94f0...`	`1413416c3b2583ad...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`dcbdcfabbc11788d...`	`3d8101d12aaed28b...`
bitcoin-0.19.99.tar.gz	`bb241ff718f90db7...`	`0ae5d69a40e142a2...`
bitcoin-core-linux-0.20-res.yml	`f0e1f78f4c673bfb...`	`9c323ae0bff3d341...`
bitcoin-core-osx-0.20-res.yml	`e7372ee66c33c5b6...`	`75e3dcde01fec173...`
bitcoin-core-win-0.20-res.yml	`b99b459febc7ce3a...`	`2c542f5cb11fd7e1...`
linux-build.log	`1d19bc4efecc2987...`	`a1af252a4cfad510...`
osx-build.log	`05276d8599182586...`	`6436c5c207f0a5d2...`
win-build.log	`a1f5423cb7e486dc...`	`ff6a89cc2f88efcb...`
bitcoin-core-linux-0.20-res.yml.diff		`6e112fc66036d343...`
bitcoin-core-osx-0.20-res.yml.diff		`0dfed83a3c8253a4...`
bitcoin-core-win-0.20-res.yml.diff		`a9fb34b37897ded5...`
linux-build.log.diff		`f95b5458410d2cc8...`
osx-build.log.diff		`71f86c7f835a02bb...`
win-build.log.diff		`1cdd0c1860f0ef16...`

DrahtBot removed the label Needs gitian build on Dec 5, 2019
promag commented at 8:03 AM on December 6, 2019: member

ACK c8becb82805ed1483e009eba682f19fe9e8b8c9c.
hebasto approved
hebasto commented at 10:04 AM on December 7, 2019: member

ACK c8becb82805ed1483e009eba682f19fe9e8b8c9c, I have reviewed the code and it looks OK, I agree it can be merged.
laanwj referenced this in commit a8f5d5c6b9 on Dec 7, 2019
laanwj merged this on Dec 7, 2019
laanwj closed this on Dec 7, 2019
sidhujag referenced this in commit 8b5b208c0b on Dec 7, 2019
fanquake deleted the branch on Dec 7, 2019
deadalnix referenced this in commit 860c087401 on Apr 3, 2020
sidhujag referenced this in commit 4992c54713 on Nov 10, 2020
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16089 depends: add ability to skip building zeromq