tests: Enable tests which are incorrectly skipped when running test_runner.py --usecli #17675

1. 
   practicalswift commented at 3:37 PM on December 5, 2019: contributor

   Annotate functional tests supporting bitcoin-cli (--usecli) as such.

   Prior to this commit 74 tests were unnecessarily skipped when running test_runner.py --usecli.

   Before:

   $ test/functional/test_runner.py --usecli > /dev/null 2>&1
   $ echo $?
   0
   $ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
       grep -E ' (Passed|Skipped) *$' | sort | uniq -c
         9  ✓ Passed
       126  ○ Skipped
   

   After:

   $ test/functional/test_runner.py --usecli > /dev/null 2>&1
   $ echo $?
   0
   $ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
       grep -E ' (Passed|Skipped) *$' | sort | uniq -c
        83  ✓ Passed
        52  ○ Skipped
   

   Context: --usecli was introduced in https://github.com/bitcoin/bitcoin/pull/11970/commits/f6ade9ce1a679a026c84e5baa9f8595fa2be78a5

2. fanquake added the label Tests on Dec 5, 2019
3. 
   DrahtBot commented at 3:55 PM on December 5, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17631 (Expose block filters over REST. by TheBlueMatt)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   laanwj commented at 9:15 AM on December 6, 2019: member

   Why do some tests not support --cli? (and wouldn't it be less hassle to mark those? with the idea of fixing them later, maybe)

5. tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such 993e38a4e2
6. practicalswift force-pushed on Dec 6, 2019
7. 
   practicalswift commented at 2:59 PM on December 6, 2019: contributor

   Why do some tests not support --cli?

   The reasons varies but the most common exception raised is TypeError: Object of type 'Decimal' is not JSON serializable. There is also OSError: [Errno 7] Argument list too long: 'bitcoin-cli' and a few others.

   (and wouldn't it be less hassle to mark those? with the idea of fixing them later, maybe)

   Good point! Now updated: that brought down the net diff from +80 to +45 (+50-5).

   Please re-review :)

8. practicalswift renamed this:
   tests: Annotate functional tests supporting bitcoin-cli (--usecli) as such
   tests: Enable tests which are incorrectly skipped when running test_runner.py --usecli
   on Dec 6, 2019
9. 
   fanquake commented at 3:15 PM on December 6, 2019: member

   You could also update rpc_deriveaddresses.py which has self.supports_cli = 1.

10. tests: Use a default of supports_cli=True (instead of supports_cli=False) 5ac804a9eb
11. 
    practicalswift commented at 3:24 PM on December 6, 2019: contributor

    @fanquake Good catch. Now updated. Please re-review :)

12. practicalswift force-pushed on Dec 6, 2019
13. 
    laanwj commented at 11:13 AM on December 9, 2019: member

    Code review ACK 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805

    TypeError: Object of type 'Decimal' is not JSON serializable

    That one should be pretty easy to fix by adding default=EncodeDecimal to json.dumps as done in functional/test_framework/authproxy.py

    (no need to do so here, though)

14. fanquake requested review from MarcoFalke on Dec 9, 2019
15. MarcoFalke referenced this in commit df2b743759 on Dec 9, 2019
16. MarcoFalke merged this on Dec 9, 2019
17. MarcoFalke closed this on Dec 9, 2019

    ---

18. fanquake referenced this in commit dd8327545c on Dec 9, 2019
19. fanquake referenced this in commit b6f9e3576a on Dec 9, 2019
20. sidhujag referenced this in commit ff974f84d4 on Dec 9, 2019
21. fanquake referenced this in commit 3f1966ead6 on Dec 12, 2019
22. sidhujag referenced this in commit 62e261894a on Dec 12, 2019
23. HashUnlimited referenced this in commit 9343f88d8e on Apr 17, 2020
24. jasonbcox referenced this in commit cc5ceb0d2e on Nov 10, 2020
25. jasonbcox referenced this in commit 47048ca9d3 on Nov 10, 2020
26. sidhujag referenced this in commit fa95ca72f0 on Nov 10, 2020
27. sidhujag referenced this in commit c2abcf8957 on Nov 10, 2020
28. backpacker69 referenced this in commit 879e69d438 on Mar 28, 2021
29. practicalswift deleted the branch on Apr 10, 2021
30. Stackout referenced this in commit 07226d95f9 on Feb 17, 2022
31. knst referenced this in commit 6ba86b174b on Jun 7, 2022
32. knst referenced this in commit 63d8c49258 on Jun 7, 2022
33. knst referenced this in commit 6dbc9aba0d on Jun 8, 2022
34. knst referenced this in commit f08497c93e on Jun 8, 2022
35. UdjinM6 referenced this in commit bcc4b2d1ac on Jun 14, 2022
36. DrahtBot locked this on Aug 16, 2022

Contributors

practicalswiftDrahtBotlaanwjfanquake

Review Requested
MarcoFalke