gui: disable File->CreateWallet during startup #17695

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:disable_early_create_wallet changing 1 files +2 −0

fanquake commented at 8:59 PM on December 7, 2019: member

Same as #16118. Early calls to Create Wallet will crash bitcoin-qt.

lldb /Applications/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt -- --regtest -debug

Process 18143 launched: '/Users/michael/github/bitcoin/src/qt/bitcoin-qt' (x86_64)
2019-12-07 15:49:37.823867-0500 bitcoin-qt[18143:5696499] MessageTracer: Falling back to default whitelist
Process 18143 stopped
* thread [#1](/bitcoin-bitcoin/1/), queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x18)
    frame [#0](/bitcoin-bitcoin/0/): 0x00000001000d2d9d bitcoin-qt`CreateWalletActivity::createWallet() + 381
bitcoin-qt`CreateWalletActivity::createWallet:
->  0x1000d2d9d <+381>: movq   0x18(%rax), %r14
    0x1000d2da1 <+385>: movq   %r15, -0xa8(%rbp)
    0x1000d2da8 <+392>: leaq   -0xa0(%rbp), %r12
    0x1000d2daf <+399>: leaq   -0x80(%rbp), %rsi
Target 0: (bitcoin-qt) stopped.
(lldb) bt
* thread [#1](/bitcoin-bitcoin/1/), queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x18)
  * frame [#0](/bitcoin-bitcoin/0/): 0x00000001000d2d9d bitcoin-qt`CreateWalletActivity::createWallet() + 381
    frame [#1](/bitcoin-bitcoin/1/): 0x0000000100833e6f bitcoin-qt`QMetaObject::activate(QObject*, int, int, void**) + 1631
    frame [#2](/bitcoin-bitcoin/2/): 0x0000000100a1fc47 bitcoin-qt`QDialog::done(int) + 247
    frame [#3](/bitcoin-bitcoin/3/): 0x0000000100833ef5 bitcoin-qt`QMetaObject::activate(QObject*, int, int, void**) + 1765
    frame [#4](/bitcoin-bitcoin/4/): 0x00000001009e04c2 bitcoin-qt`QDialogButtonBoxPrivate::_q_handleButtonClicked() + 786

gui: disable File->CreateWallet during startup d65fafc2f7
fanquake added the label GUI on Dec 7, 2019
fanquake added the label Needs backport (0.19) on Dec 7, 2019
promag commented at 9:14 PM on December 7, 2019: member

ACK d65fafc2f7d98ab2be0a0961e7a3ebe7850c1dca.
kristapsk commented at 5:46 PM on December 8, 2019: contributor

This crash is Mac-specific? Cannot reproduce with current master under Linux.
jonasschnelli commented at 6:04 AM on December 9, 2019: contributor

I don't think this is Mac specific (looks like a race). utACK d65fafc2f7d98ab2be0a0961e7a3ebe7850c1dca

I wonder if there are more race issue in the state where the wallet model hasn't been attached.
fanquake referenced this in commit c8e65ade09 on Dec 9, 2019
fanquake merged this on Dec 9, 2019
fanquake closed this on Dec 9, 2019
fanquake deleted the branch on Dec 9, 2019
MarkLTZ referenced this in commit e5b7ad980a on Dec 9, 2019
fanquake referenced this in commit d14ab7c522 on Jan 3, 2020
fanquake removed the label Needs backport (0.19) on Jan 5, 2020
fanquake commented at 11:59 PM on January 5, 2020: member

Being backported in 17858.
laanwj referenced this in commit bb123c6527 on Jan 8, 2020
jasonbcox referenced this in commit cf625f6480 on Nov 7, 2020
Munkybooty referenced this in commit 861ef02929 on Dec 9, 2021
Munkybooty referenced this in commit fc6f77f098 on Dec 9, 2021
Munkybooty referenced this in commit e32f0d5d86 on Dec 9, 2021
Munkybooty referenced this in commit 16f7583e71 on Dec 23, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#1 JSON-RPC support for mobile devices ("ultra-lightweight" clients)#2 Long-term, safe, store-of-value #3 Encrypt wallet #4 Export/Import wallet in a human readable, future-proof format #16118 gui: Enable open wallet menu on setWalletController #17858 [0.19] Backports