build: Improve configure.ac formatting #17703

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:configure_ac_formatting changing 1 files +54 −55
  1. fanquake commented at 3:38 PM on December 9, 2019: member

    Use dnl for all comments, rather than #. Remove backticks - Their usage for the bdb_prefix and qt5_prefix commands may have improved backwards compatibility in some cases, however we now require recent versions of macOS. I'm not sure why they were being used in the HAVE_STD__SYSTEM and HAVE_WSYSTEM defines.

  2. fanquake added the label Build system on Dec 9, 2019
  3. practicalswift commented at 4:26 PM on December 9, 2019: contributor

    Nice cleanup!

    ACK b3d764ac392a6de68ea77eb4c0a5dbbad01e94ef -- diff looks correct

  4. DrahtBot commented at 6:17 PM on December 9, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17398 (build: Update leveldb to 1.22+ by laanwj)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. dongcarl commented at 6:44 PM on December 9, 2019: member

    ACK b3d764ac392a6de68ea77eb4c0a5dbbad01e94ef

    Diff looks good.

  6. laanwj commented at 4:49 AM on December 10, 2019: member

    I'd slightly prefer this as two commits: one that changes the comments, one that changes the use of backticks (the latter is a real code change)

  7. hebasto commented at 6:58 AM on December 10, 2019: member

    Concept ACK.

    #-styled comments are not discarded by m4. Therefore, these changes effectively remove dnl-styled comments from the generated configure script. Is it intended?

    Refs:

  8. laanwj commented at 9:12 AM on December 10, 2019: member

    #-styled comments are not discarded by m4. Therefore, these changes effectively remove dnl-styled comments from the generated configure script. Is it intended?

    Sure, generating a smaller configure file seems better.

  9. build: Remove backticks from configure.ac 8ddcbb4e41
  10. build: Use dnl for all comments in configure.ac, rather than # 3ab1824625
  11. fanquake force-pushed on Dec 10, 2019
  12. fanquake commented at 1:36 PM on December 10, 2019: member

    I'd slightly prefer this as two commits: @laanwj I've split this into two.

  13. hebasto approved
  14. hebasto commented at 5:50 PM on December 10, 2019: member

    ACK 3ab18246254019896132d1cdb8af2dcdb213ec3b, I have reviewed the code and it looks OK, I agree it can be merged.

  15. dongcarl commented at 6:06 PM on December 10, 2019: member

    ACK 3ab18246254019896132d1cdb8af2dcdb213ec3b

  16. MarcoFalke referenced this in commit d5674c5f0f on Dec 10, 2019
  17. MarcoFalke merged this on Dec 10, 2019
  18. MarcoFalke closed this on Dec 10, 2019
  19. fanquake deleted the branch on Dec 10, 2019
  20. MarkLTZ referenced this in commit 057335e940 on Jan 12, 2020
  21. DrahtBot locked this on Dec 16, 2021
Contributors
fanquakepracticalswiftDrahtBotdongcarllaanwjhebasto
Labels
Build system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me