depends: remove Qt networking features #17730

pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:qt_no_lib_system_proxy changing 1 files +8 −1
  1. fanquake commented at 1:55 am on December 12, 2019: member

    Somewhat of a followup to removing BIP70 support in #17165. This removes networking features from our Qt build. This also removes the need to link against the CFNetwork and SystemConfiguration libraries on macOS.

     0src/qt/bitcoin-qt:
     1 /usr/lib/libSystem.B.dylib 
     2 /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 
     3 /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 
     4 /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 
     5 /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 
     6 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 
     7 /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 
     8-/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 
     9 /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 
    10 /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 
    11 /usr/lib/libc++.1.dylib 
    12-/System/Library/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 
    13 /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText 
    14 /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO 
    15 /usr/lib/libobjc.A.dylib 
    

    Introduced the -optimized-tools option; supersedes -optimized-qmake.

    optimized-qmake became optimized-tools in Qt 5.6.0. While the former still works, we can use the newer flag.

    A diff of the removed symbols is available here.

    We still need to actually build the network module, because we are using QLocalServer & QLocalSocket in the payment server.

  2. fanquake added the label Build system on Dec 12, 2019
  3. fanquake added the label Needs gitian build on Dec 12, 2019
  4. laanwj commented at 8:43 am on December 12, 2019: member

    Concept ACK

    We still need to actually build the network module, because we are using QLocalServer & QLocalSocket in the payment server.

    Yes,, this is the only cross-platform IPC mechanism that Qt has, afaik (it was at the time of 4.x).

  5. Sjors commented at 2:03 pm on December 12, 2019: member

    Concept ACK

    Tested 58f9f23 on macOS 10.15.2, was able to create a DMG and BIP20 URLs can still be opened.

  6. fanquake commented at 2:29 pm on December 12, 2019: member
    Annoyingly, the Windows build blows up without networkinterface. Looking for a workaround.
  7. fanquake force-pushed on Dec 12, 2019
  8. fanquake commented at 4:39 pm on December 12, 2019: member
    This is now ready for review. I’ve fixed the Windows build by reinstating the networkinterface feature.
  9. DrahtBot removed the label Needs gitian build on Dec 13, 2019
  10. Sjors commented at 10:08 am on December 13, 2019: member
    Tested ACK 3569e0e4bc549672aa3d4eeb5d309619355574d1 on macOS 10.15.2. I would like to see this tested on Windows and work on a repaired AppVeyor though.
  11. depends: skip building qt proxies ccdda96804
  12. depends: -optimized-qmake is now -optimized-tools 29d56c62b7
  13. depends: disable unused qt networking features 244501fc85
  14. fanquake force-pushed on Dec 13, 2019
  15. fanquake commented at 1:31 pm on December 13, 2019: member

    work on a repaired AppVeyor though.

    Rebased on master for Appveyor.

  16. MarcoFalke added the label Needs gitian build on Dec 13, 2019
  17. fanquake commented at 3:13 pm on December 13, 2019: member
    @MarcoFalke the bot built the old branch. That error is no longer relevant.
  18. MarcoFalke deleted a comment on Dec 13, 2019
  19. Sjors commented at 3:20 pm on December 13, 2019: member
    Code review ACK 244501fc85a1319857efb227093c0e71c1d5a01e: just a rebase (updated since I accidentally repeated the previous hash)
  20. practicalswift commented at 0:22 am on December 14, 2019: contributor

    ACK 244501fc85a1319857efb227093c0e71c1d5a01e – diff looks correct

    Thanks for doing these cleanups

  21. promag commented at 3:52 pm on December 14, 2019: member
    Code review ACK 244501fc85a1319857efb227093c0e71c1d5a01e.
  22. DrahtBot commented at 5:55 pm on December 14, 2019: member

    Gitian builds

    File commit c5e318aea6ad098db66e6f174f2790acc197351c(master) commit 261d979df3043ef82ddf273cb470714eec814ca3(master and this pull)
    bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz bea40f9a3e1e3d15... 1a1468d0438c548a...
    bitcoin-0.19.99-aarch64-linux-gnu.tar.gz 6062abc6a838a5a6... 39d213b6222d94c0...
    bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz 69dcc7a49e222ca9... 581789bae808dd76...
    bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz d0e369041d9fe9b5... 66f141b937fa43bb...
    bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz d3b7c55ff3c2bc2f... dffbfae69f7b596c...
    bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz ae365922d91820b9... 48a8dc0f0533338c...
    bitcoin-0.19.99-osx-unsigned.dmg d5388aa2474ac73e... 158abaec2dc845e9...
    bitcoin-0.19.99-osx64.tar.gz 4baf8f214f059caf... 2df7fa0bc8034c1f...
    bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz 6b0e20d11cb5fe6b... 5d7055cc3f5c88f8...
    bitcoin-0.19.99-riscv64-linux-gnu.tar.gz 0d45828e7aac5e93... 50bda054dd366e9c...
    bitcoin-0.19.99-win64-debug.zip 5669c48e3fad4bc5... 238ae11e10578ff6...
    bitcoin-0.19.99-win64-setup-unsigned.exe 6fc70664b2973325... aea2f18ecf4cba4b...
    bitcoin-0.19.99-win64.zip 576846961cf26ff2... 3f1bc9e0963f3c53...
    bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz 591688b38863b8b4... 6a7cc40d96ada4d5...
    bitcoin-0.19.99-x86_64-linux-gnu.tar.gz e8dcc933264b4d6c... c449874653133164...
    bitcoin-0.19.99.tar.gz 9d45221fe86cb679... f4183c4fdbca951d...
    bitcoin-core-linux-0.20-res.yml 2efef3cbffb806a2... d9c82c697f8efefd...
    bitcoin-core-osx-0.20-res.yml d2ea6d1607e9fd97... af5b9d36f91aed00...
    bitcoin-core-win-0.20-res.yml 93ecd38034110860... 88524bd7b65572f9...
    linux-build.log b3d2ce067eb93baa... 2139e073d3ac6578...
    osx-build.log f3e9977f0c38cddd... 63fe092e173a129b...
    win-build.log 91466d2d19dec4e6... 4de24548768d0858...
    bitcoin-core-linux-0.20-res.yml.diff 59307791323c198e...
    bitcoin-core-osx-0.20-res.yml.diff f2f7ee5deb06c382...
    bitcoin-core-win-0.20-res.yml.diff ecea253444bc8d99...
    linux-build.log.diff fabfe4a4d8683e7c...
    osx-build.log.diff 35eb01436ac7a0ba...
    win-build.log.diff 9ac7e7efd0559d47...
  23. DrahtBot removed the label Needs gitian build on Dec 14, 2019
  24. DrahtBot commented at 6:41 am on December 15, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  25. laanwj referenced this in commit 5e4912f990 on Dec 16, 2019
  26. laanwj merged this on Dec 16, 2019
  27. laanwj closed this on Dec 16, 2019

  28. fanquake deleted the branch on Dec 16, 2019
  29. sidhujag referenced this in commit d2ef00b117 on Dec 16, 2019
  30. sidhujag referenced this in commit 207d5ff5f3 on Nov 10, 2020
  31. kittywhiskers referenced this in commit 7dc828482b on Nov 24, 2021
  32. PastaPastaPasta referenced this in commit 25a965d691 on Nov 30, 2021
  33. MarcoFalke locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me