depends: remove Qt networking features #17730

Somewhat of a followup to removing BIP70 support in #17165. This removes networking features from our Qt build. This also removes the need to link against the CFNetwork and SystemConfiguration libraries on macOS.

src/qt/bitcoin-qt:
 /usr/lib/libSystem.B.dylib 
 /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 
 /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 
 /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 
 /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 
 /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 
 /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 
-/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 
 /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 
 /System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 
 /usr/lib/libc++.1.dylib 
-/System/Library/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 
 /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText 
 /System/Library/Frameworks/ImageIO.framework/Versions/A/ImageIO 
 /usr/lib/libobjc.A.dylib 

Introduced the -optimized-tools option; supersedes -optimized-qmake.

optimized-qmake became optimized-tools in Qt 5.6.0. While the former still works, we can use the newer flag.

A diff of the removed symbols is available here.

We still need to actually build the network module, because we are using QLocalServer & QLocalSocket in the payment server.

Concept ACK

We still need to actually build the network module, because we are using QLocalServer & QLocalSocket in the payment server.

Yes,, this is the only cross-platform IPC mechanism that Qt has, afaik (it was at the time of 4.x).

Concept ACK

Tested 58f9f23 on macOS 10.15.2, was able to create a DMG and BIP20 URLs can still be opened.

Annoyingly, the Windows build blows up without networkinterface. Looking for a workaround.

This is now ready for review. I've fixed the Windows build by reinstating the networkinterface feature.

Tested ACK 3569e0e4bc549672aa3d4eeb5d309619355574d1 on macOS 10.15.2. I would like to see this tested on Windows and work on a repaired AppVeyor though.

work on a repaired AppVeyor though.

Rebased on master for Appveyor.

@MarcoFalke the bot built the old branch. That error is no longer relevant.

Code review ACK 244501fc85a1319857efb227093c0e71c1d5a01e: just a rebase (updated since I accidentally repeated the previous hash)

ACK 244501fc85a1319857efb227093c0e71c1d5a01e -- diff looks correct

Thanks for doing these cleanups

Code review ACK 244501fc85a1319857efb227093c0e71c1d5a01e.

<!--a722867cd34abeea1fadc8d60700f111-->

Gitian builds

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

No conflicts as of last run.