PSBT file handler #17870

issue Sjors opened this issue on January 4, 2020

Sjors commented at 1:32 PM on January 4, 2020: member

#17509 introduces a Load PSBT menu option. It would be even easier if a user can double-click on a PSBT file, open it from an email, etc. For this we would need to register a file handler.

This can be done by defining a QAbstractFileEngineHandler for .psbt files, which should then call the same code as "File" -> "Load PSBT".

One potential downside of a file handler, is that it encourages users to double-click on potentially untrusted files, which might be nasty executables.
Sjors added the label Feature on Jan 4, 2020
fanquake added the label GUI on Jan 4, 2020
jonasschnelli commented at 9:21 PM on January 5, 2020: contributor

Does the .psdb file format has a header/magic?
Sjors commented at 4:07 AM on January 6, 2020: member

I don't think so: https://github.com/bitcoin/bips/blob/master/bip-0174.mediawiki#Encoding

On iOs I was able to register a filehandler on the .psbt extension, and then just try to decode it.
practicalswift commented at 11:14 PM on January 7, 2020: contributor

I don't think we should do this until the PSBT parsing issues reported in #17149 ("Potential PSBT issues found by the PSBT fuzzer") have been addressed. User safety first, second and third! :)
fanquake commented at 12:31 PM on August 10, 2020: member

Moved this to the GUI repo: https://github.com/bitcoin-core/gui/issues/52.
fanquake closed this on Aug 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels