build: remove double LIBBITCOIN_SERVER linking #17910

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_double_server changing 1 files +0 −3

fanquake commented at 1:26 am on January 12, 2020: member

Seems that this is no longer required. Have tested building on macOS and Debian.
build: remove double LIBBITCOIN_SERVER linking 831e1220bc
fanquake added the label Build system on Jan 12, 2020
fanquake added the label Needs gitian build on Jan 12, 2020
fanquake requested review from ryanofsky on Jan 12, 2020
DrahtBot commented at 3:14 am on January 12, 2020: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16367 (Multiprocess build support by ryanofsky)
- #10102 ([experimental] Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto commented at 9:56 am on January 12, 2020: member

Seems that this is no longer required.

Is it a result of #15638 ?

DrahtBot commented at 4:53 pm on January 12, 2020: member

Gitian builds

File	commit e258ce792a4849927a6db51786732d71cbbb65fc(master)	commit 4f85a32115ffc82c68143d6b7613297ecb40fd5e(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`048c99029d1f00d0...`	`d3675fd0fefb5f08...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`f5f50540f6c70397...`	`04312cf42260af6a...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`888ca1ceac12de4a...`	`2a1aef520723001a...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`484496fe668e1af6...`	`817e98eb6717cdd0...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`a6b56561f7134430...`	`f5d257ea11f12875...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`c72c6e465f9a8511...`	`c348a319a6693cf2...`
bitcoin-0.19.99-osx-unsigned.dmg	`3e4ad919f64575b4...`	`582c46f93e2ef245...`
bitcoin-0.19.99-osx64.tar.gz	`a286a84b4f1d6d7e...`	`a14649dbab7c3e6f...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`ae39ebf0b8f7a5b2...`	`3a527ebcc47a9cda...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`94a676af2324957c...`	`98a01fa855b8d937...`
bitcoin-0.19.99-win64-debug.zip	`28d487d8150eb217...`	`d7ed61bb7e94412d...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`c5536af10a6c637f...`	`5863989526e3cf64...`
bitcoin-0.19.99-win64.zip	`3ff5d481fec17519...`	`18b6617834ec8092...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`218f61bb1a4de3e5...`	`c2fb4cc2b90ac0ed...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`07e0bd193b461042...`	`318f7cbd08765182...`
bitcoin-0.19.99.tar.gz	`4d46a6481b6711f5...`	`266d7e113bf50710...`
bitcoin-core-linux-0.20-res.yml	`a1008e30a305dacd...`	`d20abb285fc4716d...`
bitcoin-core-osx-0.20-res.yml	`8e6e044e8ffea3af...`	`855cc60e8a5b57a5...`
bitcoin-core-win-0.20-res.yml	`7f7e7a30ff49851d...`	`168b18f1b5d51590...`
linux-build.log	`46a2ee98f7351bfc...`	`b99083110a6db501...`
osx-build.log	`5f8c87a00c40573d...`	`33bebe4e3ce62976...`
win-build.log	`546e31c3bb6b1ab8...`	`76e78a40f75aee2f...`
bitcoin-core-linux-0.20-res.yml.diff		`d9d7bba3b91863e4...`
bitcoin-core-osx-0.20-res.yml.diff		`4505db509098dafe...`
bitcoin-core-win-0.20-res.yml.diff		`62bbf2a732febafb...`
linux-build.log.diff		`f14c857980fb55a9...`
osx-build.log.diff		`fd0a2d602bd93793...`
win-build.log.diff		`df43d83f9c139bea...`

DrahtBot removed the label Needs gitian build on Jan 12, 2020
promag commented at 6:40 pm on January 12, 2020: member

ACK 831e1220bc151b1016412359775406b34cb8f52c.
practicalswift commented at 7:58 pm on January 12, 2020: contributor

ACK 831e1220bc151b1016412359775406b34cb8f52c
laanwj commented at 10:42 am on January 13, 2020: member

good catch, I’m happy that this is no longer needed! ACK 831e1220bc151b1016412359775406b34cb8f52c
laanwj referenced this in commit f2f9fdf579 on Jan 13, 2020
laanwj merged this on Jan 13, 2020
laanwj closed this on Jan 13, 2020
fanquake deleted the branch on Jan 13, 2020
fanquake removed review request from ryanofsky on Jan 13, 2020
MarkLTZ referenced this in commit af16195c2e on Jan 21, 2020
fanquake referenced this in commit e99ca783cd on Mar 26, 2020
sidhujag referenced this in commit da1f651363 on Mar 28, 2020
PastaPastaPasta referenced this in commit 700f54ad4f on Nov 1, 2021
PastaPastaPasta referenced this in commit 93b9968eea on Dec 22, 2021
PastaPastaPasta referenced this in commit f80ac36acb on Dec 22, 2021
DrahtBot locked this on Feb 15, 2022

Contributors
fanquake DrahtBot hebasto promag practicalswift laanwj

Labels
Build system

build: remove double LIBBITCOIN_SERVER linking #17910

Conflicts

Gitian builds