[0.18] net: Log to net category for exceptions in ProcessMessages #17974

1. 
   instagibbs commented at 3:35 pm on January 21, 2020: member

   Backport of #17762, currently only backported to 0.19.

   This seems like something we should opportunistically plug in case wiseguys decide it’s a vector to exploit to try and fill people’s disks.

2. 
   practicalswift commented at 3:45 pm on January 21, 2020: contributor

   ACK 314ba6c9360e8ff1c630a9bdc422c73fe2cc0666
3. 
   MarcoFalke commented at 5:36 pm on January 21, 2020: member

   Please use the backport script or include the backport metatdata manually. Otherwise it is hard to verify this and see where it came from without any references to the original commit/pull.
4. 
   instagibbs commented at 5:58 pm on January 21, 2020: member

   @MarcoFalke is there a TLDR for the script with deps etc or the metadata required to be included where? This should probably be a CONTIRBUTION.md thing?
5. DrahtBot added the label P2P on Jan 21, 2020
6. 
   MarcoFalke commented at 6:16 pm on January 21, 2020: member

   I think if you cherry-pick the commit from 0.19, it should include all metadata.

   There is a python helper script: https://github.com/bitcoin-core/bitcoin-maintainer-tools#backport

   Not sure if this should be generally made available for any contributor. Asking for a “needs backport” tag should be sufficient

7. fanquake added the label Backport on Jan 21, 2020
8. fanquake added this to the milestone 0.18.2 on Jan 21, 2020
9. fanquake added the label Waiting for author on Jan 21, 2020
10. 
    fanquake commented at 11:48 pm on January 21, 2020: member

    @instagibbs You can take a look at https://github.com/bitcoin/bitcoin/pull/17858/commits/1a6a534665be410988785b0f2e09ef001a612d5c for an example of the metadata required.
11. net: Log to net category for exceptions in ProcessMessages

    Remove the forest of special exceptions, and simply log a short
    message to the NET logging category when an exception happens during
    packet processing. It is not good to panick end users with errors
    that any peer can generate (let alone writing to stderr).
    
    Github-Pull: #17762
    Rebased-From: 4d88c3dcb61e7c075ed3dd442044e0eff4e3c8de

    c89611ebd3
12. instagibbs force-pushed on Jan 22, 2020
13. 
    instagibbs commented at 4:55 pm on January 22, 2020: member

    cherry-picked from 0.19
14. 
    practicalswift commented at 5:31 pm on January 22, 2020: contributor

    ACK c89611ebd33a86c0fe14adecc100065f16ea16da

    Reviewers of this PR might want to review the somewhat related PR #17828 (“net: Use log categories when logging events that P2P peers can trigger arbitrarily”).

15. MarcoFalke removed the label Waiting for author on Jan 22, 2020
16. MarcoFalke renamed this:
    net: Log to net category for exceptions in ProcessMessages
    [0.18] net: Log to net category for exceptions in ProcessMessages
    on Jan 22, 2020
17. 
    MarcoFalke commented at 6:31 pm on January 22, 2020: member

    ACK c89611ebd33a86c0fe14adecc100065f16ea16d, checked that this is a cherry-pick from 0.19 💐

    Signature:

     0-----BEGIN PGP SIGNED MESSAGE-----
     1Hash: SHA512
     2
     3ACK c89611ebd33a86c0fe14adecc100065f16ea16d, checked that this is a cherry-pick from 0.19 💐
     4-----BEGIN PGP SIGNATURE-----
     5
     6iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
     7pUhbXgwAndLCk84m8EK4oVBy9To8XcTNlaKwHHkb7ZG1f5FvFOwCbNhBh8yabG9E
     8Cs7TRlNtgbqkxuSDrINXbJUJCwpX7VAZYnvM4wO8kaEwp36KdZH4MxuvsYEYgIxD
     97QeNltUlOz3lKZxGAzWHht4NSC+FKLZa/MdmqLRbEiOsQnQHup/dww472bQsfXcD
    10fd7ymEt6MCvu7wuqRuj7QSMsuRvOcCjKr94cE2zPbpUCdkcfLRCurroCAK3hIVyQ
    11ZRM+Su+JtvJ6qKp7ncbI4beQcWrAXMxUjUCCC9+4gXsvvoFcnPmEq2EncLT8mD4Z
    12pJZzXBpda3Ob2aG7qDTYyKHJ0WSHg6Sq2NuYNpagbAE8xu2jTwxE3ObkWkzOnqZh
    13gmqnB5jHngLfRYLWqN4P7AnoGtqwmoxlsDrhUA1rwS68fP0Ky9B1NEo8cJL+l7zC
    14JyV/uyvFJkE8m/KLcExm9YzKMwYvZoSngdZgQzEBpT+IojerWhS5uJJ/Or6V5no3
    15yoMJTIRe
    16=Ms73
    17-----END PGP SIGNATURE-----
    

    Timestamp of file with hash 06c44dd31613f3547029de3f00dec7998591efe3347b67cf28d33ccd930136f9 -

18. fanquake referenced this in commit 8b67698420 on Jan 23, 2020
19. fanquake merged this on Jan 23, 2020
20. fanquake closed this on Jan 23, 2020

    ---

21. DrahtBot locked this on Feb 15, 2022

Contributors
instagibbs practicalswift MarcoFalke fanquake

Labels
P2P Backport

Milestone
0.18.2