[0.18] net: Log to net category for exceptions in ProcessMessages #17974

pull instagibbs wants to merge 1 commits into bitcoin:0.18 from instagibbs:bp18_network_exceptions changing 1 files +3 −28

instagibbs commented at 3:35 PM on January 21, 2020: member

Backport of #17762, currently only backported to 0.19.

This seems like something we should opportunistically plug in case wiseguys decide it's a vector to exploit to try and fill people's disks.
practicalswift commented at 3:45 PM on January 21, 2020: contributor

ACK 314ba6c9360e8ff1c630a9bdc422c73fe2cc0666
MarcoFalke commented at 5:36 PM on January 21, 2020: member

Please use the backport script or include the backport metatdata manually. Otherwise it is hard to verify this and see where it came from without any references to the original commit/pull.
instagibbs commented at 5:58 PM on January 21, 2020: member

@MarcoFalke is there a TLDR for the script with deps etc or the metadata required to be included where? This should probably be a CONTIRBUTION.md thing?
DrahtBot added the label P2P on Jan 21, 2020
MarcoFalke commented at 6:16 PM on January 21, 2020: member

I think if you cherry-pick the commit from 0.19, it should include all metadata.

There is a python helper script: https://github.com/bitcoin-core/bitcoin-maintainer-tools#backport

Not sure if this should be generally made available for any contributor. Asking for a "needs backport" tag should be sufficient
fanquake added the label Backport on Jan 21, 2020
fanquake added this to the milestone 0.18.2 on Jan 21, 2020
fanquake added the label Waiting for author on Jan 21, 2020
fanquake commented at 11:48 PM on January 21, 2020: member

@instagibbs You can take a look at https://github.com/bitcoin/bitcoin/pull/17858/commits/1a6a534665be410988785b0f2e09ef001a612d5c for an example of the metadata required.

net: Log to net category for exceptions in ProcessMessages

Remove the forest of special exceptions, and simply log a short
message to the NET logging category when an exception happens during
packet processing. It is not good to panick end users with errors
that any peer can generate (let alone writing to stderr).

Github-Pull: #17762
Rebased-From: 4d88c3dcb61e7c075ed3dd442044e0eff4e3c8de

c89611ebd3

instagibbs force-pushed on Jan 22, 2020
instagibbs commented at 4:55 PM on January 22, 2020: member

cherry-picked from 0.19
practicalswift commented at 5:31 PM on January 22, 2020: contributor

ACK c89611ebd33a86c0fe14adecc100065f16ea16da

Reviewers of this PR might want to review the somewhat related PR #17828 ("net: Use log categories when logging events that P2P peers can trigger arbitrarily").
MarcoFalke removed the label Waiting for author on Jan 22, 2020
MarcoFalke renamed this:
~~net: Log to net category for exceptions in ProcessMessages~~
[0.18] net: Log to net category for exceptions in ProcessMessages
on Jan 22, 2020

MarcoFalke commented at 6:31 PM on January 22, 2020: member

ACK c89611ebd33a86c0fe14adecc100065f16ea16d, checked that this is a cherry-pick from 0.19 💐

<details><summary>Show signature and timestamp</summary>

Signature:

Timestamp of file with hash 06c44dd31613f3547029de3f00dec7998591efe3347b67cf28d33ccd930136f9 -

</details>

fanquake referenced this in commit 8b67698420 on Jan 23, 2020
fanquake merged this on Jan 23, 2020
fanquake closed this on Jan 23, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Milestone
0.18.2

Linked (view graph)

#17762 net: Log to net category for exceptions in ProcessMessages