Add vcpkg custom port files #17991

1. 
   sipsorcery commented at 1:26 pm on January 23, 2020: member

   The purpose is to allow control of the vcpkg package versions installed by the appveyor CI job. The main vcpkg port files change regularly and can potentially break the Bitcoin Core build.

   • Copies the current vcpkg port files required for Bitcoin Core dependencies.
   • Updates the appveyor CI job to use custom port files.

   P.S. as discussed in #17976.

2. Add vcpkg custom port files

   The purpose is to allow control of the vcpkg package versions installed by the appveyor CI job. The main vcpkg port files change regularly and can potentially break the Bitcoin Core build.
   
   - Copies the current vcpkg port files for Bitcoin Core dependencies.
   - Updates the appveyor CI job to use custom port files.

   886f897b11
3. fanquake added the label Tests on Jan 23, 2020
4. fanquake added the label Windows on Jan 23, 2020
5. 
   sipsorcery commented at 1:55 pm on January 23, 2020: member

   I think the linter will need to be turned off for build_msvc\vcpkg-ports. Otherwise it will be a never ending task keeping the port files in sync with the main vcpkg repo.

   Anyone know if I can and if so where I add a linter exclusion?

6. 
   MarcoFalke commented at 2:25 pm on January 23, 2020: member

   See test/lint/lint-whitespace.sh
7. 
   laanwj commented at 2:29 pm on January 23, 2020: member

   Concept ACK, but adding 335 files to the repository is a bit too much, IMO. I’m not sure it is good to add that to the maintenance bottleneck. Should we create a new repo for this?
8. 
   sipsorcery commented at 4:24 pm on January 23, 2020: member

   +1 for a separate repo.
9. 
   fanquake commented at 6:13 am on January 24, 2020: member

   Concept ACK, but adding 335 files to the repository is a bit too much, IMO. I’m not sure it is good to add that to the maintenance bottleneck. Should we create a new repo for this?

   +1 for a separate repo. I’d rather remove build_msvc/ and appveyor.yml from this repository then have to add ~300 files just to try and pin some dependencies.

10. 
    sipsorcery commented at 8:33 am on January 24, 2020: member

    I’d rather remove build_msvc/ and appveyor.yml from this repository then have to add ~300 files just to try and pin some dependencies.

    Only the port files need to be put in a separate repo. The existing build_msvc directory can stay as is.

    I’ll create a repo on my account to demonstrate how it works. It can be switched over to a Bitcoin Core repo afterwards if that’s deemed appropriate.

11. sipsorcery closed this on Jan 24, 2020

    ---

12. DrahtBot locked this on Feb 15, 2022

Contributors
sipsorcery MarcoFalke laanwj fanquake

Labels
Windows Tests