build: remove --large-address-aware linker flag #18003

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:configure_large_address_aware changing 1 files +0 −2
  1. fanquake commented at 2:45 AM on January 26, 2020: member

    This flag was used when building 32-bit Windows executables, which we no-longer do, and is not accepted by the linker for any of the hosts we currently build for. i.e:

    checking whether the linker accepts -Wl,--large-address-aware... no
    

    --large-address-aware If given, the appropriate bit in the "Characteristics" field of the COFF header is set to indicate that this executable supports virtual addresses greater than 2 gigabytes. This should be used in conjunction with the /3GB or /USERVA=value megabytes switch in the "[operating systems]" section of the BOOT .INI. Otherwise, this bit has no effect. [This option is specific to PE targeted ports of the linker]

    You can check that the appropriate bit in the COFF header of our 64-bit Windows binaries is still be set using dumpbin. i.e:

    dumpbin /headers .\bitcoind.exe 
    
    FILE HEADER VALUES
    <snip>
    26 characteristics
         Executable
         Line numbers stripped
         Application can handle large (>2GB) addresses
    
  2. build: remove --large-address-aware linker flag
    This flag was used when building 32-bit Windows executables, which we no-longer 
    do, and is not accepted by the linker for any of the hosts we currently build 
    for. i.e:
    
    ```bash
    checking whether the linker accepts -Wl,--large-address-aware... no
    ```
    
    --large-address-aware
        If given, the appropriate bit in the "Characteristics" field of the COFF
        header is set to indicate that this executable supports virtual addresses
        greater than 2 gigabytes. This should be used in conjunction with the /3GB
        or /USERVA=value megabytes switch in the "[operating systems]" section of
        the BOOT .INI. Otherwise, this bit has no effect. [This option is specific
        to PE targeted ports of the linker]
    
    You can check that the appropriate bit in the COFF header of our current
    Windows binaries is still be set using dumpbin. i.e:
    
    ```powershell
    dumpbin /headers .\bitcoind.exe 
    
    FILE HEADER VALUES
    <snip>
    26 characteristics
         Executable
         Line numbers stripped
         Application can handle large (>2GB) addresses
    ```
    acd644b83d
  3. fanquake added the label Build system on Jan 26, 2020
  4. fanquake added the label Needs gitian build on Jan 26, 2020
  5. fanquake requested review from theuni on Jan 26, 2020
  6. fanquake requested review from dongcarl on Jan 26, 2020
  7. DrahtBot commented at 6:11 AM on January 26, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #17874 (build: make linker checks more robust by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. practicalswift commented at 8:33 AM on January 26, 2020: contributor

    Concept ACK: thanks for cleaning up old cruft in the build system

  9. DrahtBot commented at 8:55 PM on January 26, 2020: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds

    File commit b4f832e24e779980e5dbf1ea67b41e478feb9022<br>(master) commit c5227a9d0a949705e3fdd4dbc935d4b03f26262b<br>(master and this pull)
    bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz b958ef81cddc3493... b3452f5abcc044b8...
    bitcoin-0.19.99-aarch64-linux-gnu.tar.gz c747e27d8299a473... a8014b3fb01a47c6...
    bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz 4cc32419754bb686... a2b2be2f1fe2c53c...
    bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz b8363299a952fc15... f03cfa75ce956eb2...
    bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz 4c90cea665510676... cd3f8e10eacf6516...
    bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz c81c5b5a88c7d5a7... 65fd1a9349d33eee...
    bitcoin-0.19.99-osx-unsigned.dmg 52256351f9aed8a3... fc5a6d813657c676...
    bitcoin-0.19.99-osx64.tar.gz 8c1d72993d0dbf29... ae253c30a2093448...
    bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz 453de99ad6d67667... 4e09148de320e75a...
    bitcoin-0.19.99-riscv64-linux-gnu.tar.gz 7272c737b8e9f217... d17d0f4b2defbacd...
    bitcoin-0.19.99-win64-debug.zip b98df11ab5966aa4... 8bed857d7fc660f2...
    bitcoin-0.19.99-win64-setup-unsigned.exe 92cb6537a7386828... 432e97e2ff7d9e26...
    bitcoin-0.19.99-win64.zip d99406271fa61913... 6944e7e193ea5951...
    bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz 688f56b5f23b444d... 0923e9021495b39c...
    bitcoin-0.19.99-x86_64-linux-gnu.tar.gz 6c938a1fe327bbc5... c26ee6a4e679a301...
    bitcoin-0.19.99.tar.gz 3d52cc2a3bdd5763... b6ec824a6c0c3803...
    bitcoin-core-linux-0.20-res.yml ba62806ecce62469... 524e72a33b700f98...
    bitcoin-core-osx-0.20-res.yml e243cfd7780bd425... 7fcee3bc4b995c22...
    bitcoin-core-win-0.20-res.yml db4a2c7277e47c0e... dd91dfb16f11bb3c...
    linux-build.log 32a751969e04d46a... 370a9ccc55b477c5...
    osx-build.log 5ca1feba5cca178d... c9e39c52bda8d6b6...
    win-build.log 5abaa7e96528b365... 15d47b9d8f774cdd...
    bitcoin-core-linux-0.20-res.yml.diff 37932382e2778af5...
    bitcoin-core-osx-0.20-res.yml.diff f849e3f75c7f8379...
    bitcoin-core-win-0.20-res.yml.diff db37b37b19c981c3...
    linux-build.log.diff 96e48f31b8e6dab5...
    osx-build.log.diff 360f3208aa5c7727...
    win-build.log.diff f9e5942133795fbd...
  10. DrahtBot removed the label Needs gitian build on Jan 26, 2020
  11. laanwj commented at 1:23 PM on February 5, 2020: member

    ACK acd644b83d789a6cdfbeda19732119534d10058e

  12. fanquake referenced this in commit 4d211c8da1 on Feb 6, 2020
  13. fanquake merged this on Feb 6, 2020
  14. fanquake closed this on Feb 6, 2020

  15. fanquake deleted the branch on Feb 6, 2020
  16. fanquake removed review request from theuni on Feb 6, 2020
  17. fanquake removed review request from dongcarl on Feb 6, 2020
  18. sidhujag referenced this in commit 065dbb1fd7 on Feb 9, 2020
  19. luke-jr referenced this in commit 3fd3dd3776 on Jun 9, 2020
  20. sidhujag referenced this in commit 6fc395a1ad on Nov 10, 2020
  21. luke-jr referenced this in commit c42c7375d7 on Nov 17, 2020
  22. luke-jr referenced this in commit fa6f4cdf59 on Nov 25, 2020
  23. zkbot referenced this in commit 372f695d4d on Jun 5, 2021
  24. PastaPastaPasta referenced this in commit 8d6af9316a on Jun 27, 2021
  25. PastaPastaPasta referenced this in commit ca35867457 on Jun 28, 2021
  26. PastaPastaPasta referenced this in commit 8a48ad7786 on Jun 29, 2021
  27. PastaPastaPasta referenced this in commit 964e2e767d on Jul 1, 2021
  28. PastaPastaPasta referenced this in commit 37a2d6d768 on Jul 1, 2021
  29. PastaPastaPasta referenced this in commit 916a014419 on Jul 14, 2021
  30. PastaPastaPasta referenced this in commit 7e0f87b538 on Sep 17, 2021
  31. PastaPastaPasta referenced this in commit b93a9e2ad2 on Sep 18, 2021
  32. thelazier referenced this in commit 5b26683e08 on Sep 25, 2021
  33. luke-jr referenced this in commit 79bad582f8 on Oct 6, 2021
  34. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me