Made a small refactor of the arith_uint256 class. Remove a compareTo method which is redundant because can be used memcmp function.
refactor: add small refactor #18006
pull Mr-Leshiy wants to merge 1 commits into bitcoin:master from Mr-Leshiy:mrleshiy/arith_uint256_refactor changing 2 files +6 −23-
Mr-Leshiy commented at 12:56 PM on January 26, 2020: contributor
-
add small refactor 50957b1332
- Mr-Leshiy requested review from practicalswift on Jan 26, 2020
-
emilengler commented at 1:12 PM on January 26, 2020: contributor
nit: Rename your Pull Request to
refactor: add small refactor - Mr-Leshiy renamed this:
add small refactor
refactor: add small refactor
on Jan 26, 2020 -
fanquake commented at 1:51 PM on January 26, 2020: member
Thanks, however these kinds of refactors generally aren't accepted, and it's clear you didn't run any of our unit tests before opening this PR. If you're interested in contributing, I'd suggest taking a look at the good first issue list.
- fanquake closed this on Jan 26, 2020
-
theStack commented at 1:55 PM on January 26, 2020: member
NACK, this doesn't work (see failed arith_uint256_tests in AppVeyor build): uint256 stores the number in Little Endian format, i.e. the most significant byte is at higher address, whereas memcmp would work with Big Endian format, i.e. most significant byte is at lower address.
- fanquake locked this on Feb 24, 2020
Contributors
