test: Set catch_system_errors=no on boost unit tests #18183

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2002-testNoCatchSystemErrors changing 1 files +1 −1

MarcoFalke commented at 12:17 AM on February 20, 2020: member

Closes #16700

Can be tested by adding an assert(0) and then running either make check or ./src/test/test_bitcoin -t bla_tests --catch_system_errors=no/yes
test: Set catch_system_errors=no on boost unit tests fac52dafa0
MarcoFalke added the label Tests on Feb 20, 2020
practicalswift commented at 7:08 AM on February 20, 2020: contributor

ACK fac52dafa013047b051ca7163cc30ac69ad35531

Empact commented at 8:55 PM on February 21, 2020: member

Tested ACK https://github.com/bitcoin/bitcoin/pull/18183/commits/fac52dafa013047b051ca7163cc30ac69ad35531

Before: Hangs until ^C:

Running tests: bip32_tests from test/bip32_tests.cpp
Running tests: coinselector_tests from wallet/test/coinselector_tests.cpp
Running tests: init_tests from wallet/test/init_tests.cpp
Running tests: ismine_tests from wallet/test/ismine_tests.cpp
Running tests: scriptpubkeyman_tests from wallet/test/scriptpubkeyman_tests.cpp
^Cmake[3]: *** [test/bip32_tests.cpp.test] Interrupt: 2
make[2]: *** [check-am] Interrupt: 2
make[1]: *** [check-recursive] Interrupt: 2
make: *** [check-recursive] Interrupt: 2

After:

Entering test module "Bitcoin Core Test Suite"
test/bip32_tests.cpp:125: Entering test suite "bip32_tests"
test/bip32_tests.cpp:127: Entering test case "bip32_test1"
2020-02-21T20:35:52Z Seed: Setting random seed for current tests to RANDOM_CTX_SEED=5a95da1e08216910a312eaf42a405485103a7e3e8128995bc2eb93fdff142ca5
2020-02-21T20:35:52Z Bitcoin Core version v0.19.99.0-fac52dafa-dirty (release build)
2020-02-21T20:35:52Z Using 16 MiB out of 32/2 requested for signature cache, able to store 524288 elements
2020-02-21T20:35:52Z Using 16 MiB out of 32/2 requested for script execution cache, able to store 524288 elements
Assertion failed: (0), function RunTest, file test/bip32_tests.cpp, line 105.
make[3]: *** [test/bip32_tests.cpp.test] Error 1
make[3]: *** Waiting for unfinished jobs....

MarcoFalke merged this on Feb 21, 2020
MarcoFalke closed this on Feb 21, 2020
MarcoFalke deleted the branch on Feb 21, 2020
sidhujag referenced this in commit b69fd1e704 on Feb 22, 2020
deadalnix referenced this in commit 1a60077296 on Oct 21, 2020
deadalnix referenced this in commit 38a2383ced on Oct 22, 2020
sidhujag referenced this in commit c2a4db207c on Nov 10, 2020
PastaPastaPasta referenced this in commit a5ff578062 on Jun 27, 2021
PastaPastaPasta referenced this in commit ea0e6550b1 on Jun 28, 2021
PastaPastaPasta referenced this in commit 7801e7b965 on Jun 29, 2021
PastaPastaPasta referenced this in commit 44ee0fd3e9 on Jul 1, 2021
PastaPastaPasta referenced this in commit b1968646ab on Jul 1, 2021
PastaPastaPasta referenced this in commit d74366e54b on Jul 14, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#16700 test: boost unit tests don't handle assert very well