As explained in #17864 there is a missing step that was required to finish the compilation for Bitcoin Core on Windows.
doc: add missing step in win deployment instructions #18212
pull dangershony wants to merge 1 commits into bitcoin:master from dangershony:patch-1 changing 1 files +2 −0-
dangershony commented at 2:13 PM on February 27, 2020: contributor
-
7644567758
Add missing step in win deployment instructions
As explained in #17864 there is a missing step that was required to finish the compilation for bitcoin core on windows
- nopara73 approved
-
nopara73 commented at 2:17 PM on February 27, 2020: none
Tested ACK. We were setting up the dev environment together on separate machines. While there are other nuances, this may be the single largest blocker for anyone trying to compile. The rationale described here: #17864 (comment)
-
nopara73 commented at 2:19 PM on February 27, 2020: none
For reference for future readers who are also struggling with it, the conversation between @sipsorcery and @Softwareminister at #17864 is insightful.
- DrahtBot added the label Docs on Feb 27, 2020
-
sipsorcery commented at 4:28 PM on February 27, 2020: member
ACK 76445677586a4c2fa72606b662269a4390c2e71f.
Strictly speaking the
vcpkg integrate installcommand is part of thevcpkginstall. But looks like it's something easily missed so no harm adding to these instructions as well. -
dangershony commented at 6:09 PM on February 27, 2020: contributor
Also relevant #17885 by @MithrilMan
-
dangershony commented at 6:11 PM on February 27, 2020: contributor
But looks like it's something easily missed so no harm adding to these instructions as well.
Agree this is the reasoning we had too, no harm and may save hours of digging around in old issues.
-
fanquake commented at 12:36 AM on February 28, 2020: member
Strictly speaking the vcpkg integrate install command is part of the vcpkg install.
Yea, this is more "how to setup your package manager", and I thought
vcpkgexplicitly told you to do this after installation; but sure, we can merge this. - fanquake renamed this:
Add missing step in win deployment instructions.
doc: add missing step in win deployment instructions
on Feb 28, 2020 - fanquake merged this on Feb 28, 2020
- fanquake closed this on Feb 28, 2020
- dangershony deleted the branch on Feb 28, 2020
- DrahtBot locked this on Feb 15, 2022
