wip: gui: Refactor to drop client and wallet models setters #18239

1. 
   promag commented at 7:56 am on March 2, 2020: member

   This change makes the code simpler as the client and wallet models are set in the constructor and are constant.

   Based on #18064, only bbb33d6.

   This does’t change behavior.

2. gui: Drop WalletModel dependency to RecentRequestsTableModel bbb33d6431
3. gui: Pass client and wallet models to WalletView constructor c461ea0156
4. gui: Pass wallet model to ReceiveCoinsDialog constructor a9cfc2f113
5. gui: Drop ReceiveCoinsDialog::setModel 9c73fd9147
6. gui: Pass client and wallet models to SendCoinsDialog constructor 6ab499d89a
7. fanquake added the label GUI on Mar 2, 2020
8. promag renamed this:
   gui: Refactor to drop client and wallet models setters
   wip: gui: Refactor to drop client and wallet models setters
   on Mar 2, 2020
9. gui: Drop setClientModel and setModel from SendCoinsDialog 845bb528db
10. promag force-pushed on Mar 2, 2020
11. 
    DrahtBot commented at 11:04 am on March 2, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18278 (interfaces: Describe and follow some code conventions by ryanofsky)
    • #18246 (wip: gui: Drop connectSlotsByName usage by promag)
    • #17966 (qt, refactor: Optimize signal-slot connections logic by hebasto)
    • #17956 (gui: Disable unavailable context menu items in transactions tab by kristapsk)
    • #17950 (gui: Check the strength of an encryption password by emilengler)
    • #17905 (gui: Avoid redundant tx status updates by ryanofsky)
    • #17877 (qt, refactor: Make enums in BitcoinUnits class scoped by hebasto)
    • #17611 (gui: Make send and receive widgets extend QWidget by promag)
    • #17597 (qt: Fix height of QR-less ReceiveRequestDialog by hebasto)
    • #16528 (Native Descriptor Wallets using DescriptorScriptPubKeyMan by achow101)
    • #16432 (qt: Add privacy to the Overview page by hebasto)
    • #15768 (gui: Add close window shortcut by IPGlider)
    • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. promag force-pushed on Mar 2, 2020
13. gui: Drop setClientModel from WalletView 7dd43be812
14. gui: Drop setWalletModel from WalletView 2985a9774f
15. gui: Drop setClientModel from OverviewPage b5daaca8e0
16. gui: Drop setWalletModel from OverviewPage 6c9e7bd884
17. fixups 2f6dd72005
18. promag force-pushed on Mar 2, 2020
19. gui: Pass wallet model to TransactionView constructor f779a8f35d
20. gui: Drop setModel from TransactionView fd31bad0e7
21. gui: Drop setModel from ReceiveRequestDialog 60e0b96d6f
22. gui: Drop setModel from SignVerifyMessageDialog f2d761e0d7
23. gui: Drop setModel from AskPassphraseDialog fab1ce81e8
24. 
    hebasto commented at 11:24 am on March 3, 2020: member

    Concept ACK on including models in class invariants where appropriate.
25. DrahtBot added the label Needs rebase on Mar 23, 2020
26. 
    DrahtBot commented at 10:01 pm on March 23, 2020: member

    🐙 This pull request conflicts with the target branch and needs rebase.

27. 
    fanquake commented at 12:30 pm on July 9, 2020: member

    This is based on a PR that has since been closed (#18064), itself hasn’t seen any review and currently needs a rebase. If it’s still relevant them I’m going to suggest re-opening it in https://github.com/bitcoin-core/gui.
28. fanquake closed this on Jul 9, 2020

    ---

29. fanquake removed the label Needs rebase on Jul 9, 2020
30. DrahtBot locked this on Feb 15, 2022

Contributors
promag DrahtBot hebasto fanquake

Labels
GUI