build: Remove Boost Chrono

fanquake commented at 2:12 am on March 5, 2020: member

We no longer use Boost Chrono.

fanquake added the label Build system on Mar 5, 2020

DrahtBot commented at 7:18 am on March 5, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#18077 (net: Add NAT-PMP port forwarding support by hebasto)
#15421 (torcontrol: Launch a private Tor instance when not already running by luke-jr)
#15382 (util: add runCommandParseJSON by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj commented at 3:00 pm on March 5, 2020: member

Concept ACK

jonatack commented at 3:50 pm on March 5, 2020: member

Concept ACK

practicalswift commented at 9:43 pm on March 5, 2020: contributor

Concept ACK

laanwj commented at 10:21 pm on March 6, 2020: member

Needs rebase now that #16117 and #18234 have been merged.

fanquake force-pushed on Mar 6, 2020

fanquake marked this as ready for review on Mar 6, 2020

fanquake renamed this:
~~[WIP] build: Remove Boost Chrono~~
build: Remove Boost Chrono
on Mar 6, 2020

fanquake commented at 10:47 pm on March 6, 2020: member

Needs rebase now that #16117 and #18234 have been merged. @laanwj done.

build: remove chrono package from depends Boost 1d0a87e712

build: remove Boost Chrono detection from build system bd37f2bc26

test: remove Boost Chrono installation from CI e21fa542b1

doc: remove Boost Chrono from install docs ad345909b2

fanquake force-pushed on Mar 7, 2020

MarcoFalke requested review from MarcoFalke on Mar 7, 2020

in depends/packages/boost.mk:25 in ad345909b2

21@@ -22,7 +22,7 @@ $(package)_config_opts_armv7a_android=address-model=32
22 $(package)_toolset_$(host_os)=gcc
23 $(package)_archiver_$(host_os)=$($(package)_ar)
24 $(package)_toolset_darwin=clang-darwin
25-$(package)_config_libraries=chrono,filesystem,system,thread,test
26+$(package)_config_libraries=filesystem,system,thread,test

MarcoFalke commented at 2:57 pm on March 7, 2020:

We also/still depend on boost datetime, but it seems this one is a dependency of boost thread, so implicitly included here?

See also the apt command that installs datetime as a dependency of thread:

0# apt install libboost-thread-dev
1Reading package lists... Done
2Building dependency tree       
3Reading state information... Done
4The following additional packages will be installed:
5  libboost-atomic1.71-dev libboost-atomic1.71.0 libboost-chrono1.71-dev libboost-chrono1.71.0
6  libboost-date-time1.71-dev libboost-date-time1.71.0 libboost-serialization1.71-dev libboost-serialization1.71.0
7  libboost-thread1.71-dev libboost-thread1.71.0

dongcarl commented at 8:46 pm on March 9, 2020:

Perhaps, but I think we should only declare the libraries we explicitly need (just in case the dependency edges get pruned in the future).

Also, according to the docs for our version of Boost.Thread

Boost.Chrono: This dependency is optional (see below how to configure) and you will need to link with the library if you use some of the time related interfaces.

MarcoFalke commented at 2:58 pm on March 7, 2020: member

ACK ad345909b2465a65ee023b389fae342088e2f187

MarcoFalke added the label Needs gitian build on Mar 8, 2020

DrahtBot removed the label Needs gitian build on Mar 8, 2020

MarcoFalke added the label Needs gitian build on Mar 8, 2020

DrahtBot commented at 1:45 am on March 10, 2020: member

Gitian builds

File	commit 5e12a61044b15e4e29ac786135a9ebb72d1bfc61(master)	commit 4bc9160c14545c4df0a31459f7646bf2a24069a4(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`e6cb94d04f1abcf1...`	`3b6b3238f936d4a5...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`97161e6985569a03...`	`111af00872710d21...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`87a5e6118f238293...`	`b27a0a81ee2322fb...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`39ebf03fb11f3ace...`	`1c2ba17d12dc6916...`
bitcoin-0.19.99-osx-unsigned.dmg	`f9b55482380a630a...`	`d929874575f0f668...`
bitcoin-0.19.99-osx64.tar.gz	`1251fa17a137ae23...`	`648909711ca3b7d5...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`6a0a353ccff862f1...`	`258aed97650a32f4...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`aa2faf0fec1a947b...`	`bf25602c20756f54...`
bitcoin-0.19.99-win64-debug.zip	`5ba8f0938fb6c7d0...`	`fe7e9d68d49296e2...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`48f6c83889797b89...`	`2cc04949e468153e...`
bitcoin-0.19.99-win64.zip	`aa38746621abfd24...`	`0ddcf680b550d7f8...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`8fe052cc204ffec2...`	`9e1ea51f351c4208...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`9fa724a272d50ae3...`	`ad1333baa55211ff...`
bitcoin-0.19.99.tar.gz	`3488bba1d7270af0...`	`1272a99071f7706e...`
bitcoin-core-linux-0.20-res.yml	`d003ae2d67034f6f...`	`529ef817bfb0fbad...`
bitcoin-core-osx-0.20-res.yml	`e949f4b25e3434c9...`	`c6be10d153ff8bb4...`
bitcoin-core-win-0.20-res.yml	`831f173382d278e5...`	`16a07b7640971591...`
linux-build.log	`9c8f603591ab3c74...`	`8bbfe9c7cae86a14...`
osx-build.log	`871251c5bfbca1ce...`	`4a682fccf52df3ba...`
win-build.log	`1a130d28b81b87ac...`	`85a20fa9cf274a02...`
bitcoin-core-linux-0.20-res.yml.diff		`8999d179fec6815a...`
bitcoin-core-osx-0.20-res.yml.diff		`1ecb464b8ab0d06e...`
bitcoin-core-win-0.20-res.yml.diff		`47a60990f2e5e0d6...`
linux-build.log.diff		`003a6ba93f021b45...`
osx-build.log.diff		`e91218b35e897c69...`
win-build.log.diff		`ed41f1bc65bd4797...`

DrahtBot removed the label Needs gitian build on Mar 10, 2020

kallewoof commented at 2:44 am on March 10, 2020: member

ACK ad345909b2465a65ee023b389fae342088e2f187

fanquake deleted a comment on Mar 10, 2020

practicalswift commented at 7:59 am on March 10, 2020: contributor

ACK ad345909b2465a65ee023b389fae342088e2f187

Thanks for doing this excellent cleanup work. Great feeling seeing Boost get purged.

fanquake merged this on Mar 10, 2020

fanquake closed this on Mar 10, 2020

fanquake deleted the branch on Mar 10, 2020

sidhujag referenced this in commit 09ef106fef on Mar 11, 2020

jasonbcox referenced this in commit 3423c3f33e on Sep 23, 2020

sidhujag referenced this in commit 9de88a152d on Nov 10, 2020

PastaPastaPasta referenced this in commit ff632333ae on Dec 6, 2021

DrahtBot locked this on Feb 15, 2022

build: Remove Boost Chrono #18264

Conflicts

Gitian builds