build: fix libevent linking errors for bench-only builds

brakmic commented at 2:56 pm on March 18, 2020: contributor

This PR fixes the linking errors for bench-only builds by adding a -levent flag to EVENT_LIBS.

Additionally, it fixes a typo in $(EVENT_CFLAGS) and removes the double $(LIBBITCOIN_SERVER) linking entry, because a similar one was also fixed in the Makefile.am: #17910

Fixes https://github.com/bitcoin/bitcoin/issues/18373

fanquake added the label Build system on Mar 18, 2020

MarcoFalke added the label Needs gitian build on Mar 18, 2020

DrahtBot commented at 3:23 pm on March 18, 2020: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

Empact commented at 9:09 pm on March 18, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/18377/commits/4f20bcb01798679dc4f7dd904e8df52f8fbed093 code review + built locally before and after on Mac

DrahtBot removed the label Needs gitian build on Mar 19, 2020

build: fix libevent linking errors for bench-only builds f8e4e0446e

in src/Makefile.bench.include:74 in 4f20bcb017 outdated

70@@ -72,7 +71,7 @@ bench_bench_bitcoin_SOURCES += bench/wallet_balance.cpp
71 endif
72 
73 bench_bench_bitcoin_LDADD += $(BOOST_LIBS) $(BDB_LIBS) $(EVENT_PTHREADS_LIBS) $(EVENT_LIBS) $(MINIUPNPC_LIBS)
74-bench_bench_bitcoin_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS)
75+bench_bench_bitcoin_LDFLAGS = $(RELDFLAGS) $(AM_LDFLAGS) $(LIBTOOL_APP_LDFLAGS) -levent

laanwj commented at 2:15 pm on March 19, 2020:

Please use $(EVENT_LIBS) instead of -levent directly.

brakmic commented at 3:01 pm on March 19, 2020:

Code updated.

MarcoFalke added the label Needs gitian build on Mar 19, 2020

DrahtBot commented at 4:44 am on March 20, 2020: member

Gitian builds

File	commit 67de1ee8bc18afff0f2f9f203803467a2274bfc1(master)	commit e49da8dc77879daa3a9c452ff82c8cdcfada2d0b(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`0e9d652ab5beec7c...`	`95b12bf7194795a4...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`37bd1d1ee28c8749...`	`008a01f1e3732b72...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`65cb3b95f16f39cb...`	`2abb7c0eb4d6eb5f...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`4b390568c8bb8f1d...`	`c4d4e5e0679fc621...`
bitcoin-0.19.99-osx-unsigned.dmg	`b6b7e8e8d2d213b6...`	`c15da2d927315717...`
bitcoin-0.19.99-osx64.tar.gz	`8c1423b90711cbe8...`	`d3c22f07cc02a008...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`2fd002c7ea975ae1...`	`2201f2daf6f5bb2d...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`bf93f5e22290630f...`	`2c6786929db47038...`
bitcoin-0.19.99-win64-debug.zip	`6db4c26e506f77dd...`	`8d0d642dcb0295f2...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`2cac65f36b008bad...`	`59038eb9d8720a19...`
bitcoin-0.19.99-win64.zip	`cb84b196618a3f1c...`	`765e0f86da773635...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`e8a5847581b5956a...`	`ee4631328d65626c...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`638056af9469e340...`	`a8c72276f53199f0...`
bitcoin-0.19.99.tar.gz	`e9069d18ac0dfa2c...`	`01802a28ba3ebf5b...`
bitcoin-core-linux-0.20-res.yml	`4eea4cd878134890...`	`8a87a2dd2de9100d...`
bitcoin-core-osx-0.20-res.yml	`ffde76c76290ea7d...`	`fab6938110234b0c...`
bitcoin-core-win-0.20-res.yml	`bae7a1dca0f4345b...`	`082a45bed90128b3...`
linux-build.log	`927864b31f0ef2f7...`	`415ad8f3734aa2a3...`
osx-build.log	`fe837be4c466c733...`	`3ed3f355b98bc916...`
win-build.log	`5c2334ca8b827c8a...`	`e32fa7167ee15975...`
bitcoin-core-linux-0.20-res.yml.diff		`e8c13d01b9bdc13b...`
bitcoin-core-osx-0.20-res.yml.diff		`4b4926de2ebc02af...`
bitcoin-core-win-0.20-res.yml.diff		`091d65927963af36...`
linux-build.log.diff		`8b53fdd6055ae5f0...`
osx-build.log.diff		`2b7ae8f750b7cecf...`
win-build.log.diff		`87f30f6a835ae0cf...`

DrahtBot removed the label Needs gitian build on Mar 20, 2020

MarcoFalke added the label Needs gitian build on Mar 20, 2020

MarcoFalke deleted a comment on Mar 20, 2020

DrahtBot commented at 5:36 am on March 21, 2020: member

Gitian builds

File	commit 5bf45fe2a9642f8ae8f8a12bcbf8f8b4770421ad(master)	commit 21dedf9d5de1936536ac2439a04e31108a4299ed(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`b22d53a17559ca60...`	`8bc2505078ab40a3...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`0c9a5d8774b2af8d...`	`5c13c18f18fbb9a6...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`ec367ad80fb3d38c...`	`998eaed7286ff3c3...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`422b2df32e15c86e...`	`680b007397063aff...`
bitcoin-0.19.99-osx-unsigned.dmg	`400859ceb32937ef...`	`cbfeba13247fb021...`
bitcoin-0.19.99-osx64.tar.gz	`592d01b95db0fcc2...`	`34f823306c24096a...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`3f3b7a8a49f6ef74...`	`958717fa63dbb449...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`e2f2f0829f15274b...`	`f406e7a174fb9c23...`
bitcoin-0.19.99-win64-debug.zip	`ea387f7be17ebdac...`	`b99da6e6976b4985...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`9a47ac4a9a082577...`	`639fd751e9a0a2fe...`
bitcoin-0.19.99-win64.zip	`2b0fa9d48800ca97...`	`0104cfd494c7f295...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`7ac3305ca3ad57d9...`	`7ac8a0ddf765b629...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`fb048392882b021d...`	`0265dd88bd96c3fb...`
bitcoin-0.19.99.tar.gz	`0d103a4489a2b12f...`	`6154c09311a728a8...`
bitcoin-core-linux-0.20-res.yml	`0e8473886335bfb1...`	`26be13804db71cfd...`
bitcoin-core-osx-0.20-res.yml	`e179fc2662f698f7...`	`02b313957f631ae4...`
bitcoin-core-win-0.20-res.yml	`6930350677d39138...`	`bf59f4b8c0196490...`
linux-build.log	`f09f65b35309bf6e...`	`7bfc8c53f70e8ee3...`
osx-build.log	`5fdfe8b124613a2c...`	`ff8d18b1bf3fc803...`
win-build.log	`756f9f6d2f891482...`	`712065451761d926...`
bitcoin-core-linux-0.20-res.yml.diff		`3eb7337b88911be6...`
bitcoin-core-osx-0.20-res.yml.diff		`6f60be3c2c980288...`
bitcoin-core-win-0.20-res.yml.diff		`1d38c6354b7926ba...`
linux-build.log.diff		`9bf3e63444bb1563...`
osx-build.log.diff		`86a7460e6e4099d8...`
win-build.log.diff		`4533cf1102744632...`

DrahtBot removed the label Needs gitian build on Mar 21, 2020

hebasto commented at 12:31 pm on March 21, 2020: member

Please look into #18397.

brakmic commented at 12:43 pm on March 21, 2020: contributor

@hebasto ,

Thanks. Should I close this PR then?

fanquake commented at 8:00 am on March 25, 2020: member

Yes, lets use the approach in #18397. Some of your changes are included there as well.

fanquake closed this on Mar 25, 2020

brakmic deleted the branch on Mar 25, 2020

brakmic commented at 12:31 pm on March 25, 2020: contributor

Yes, lets use the approach in #18397. Some of your changes are included there as well.

Btw. I will open a new PR regarding the double $(LIBBITCOIN_SERVER).

fanquake referenced this in commit d8ce27ff9f on Mar 26, 2020

fanquake referenced this in commit e99ca783cd on Mar 26, 2020

sidhujag referenced this in commit af0f536a13 on Mar 28, 2020

sidhujag referenced this in commit da1f651363 on Mar 28, 2020

PastaPastaPasta referenced this in commit 700f54ad4f on Nov 1, 2021

PastaPastaPasta referenced this in commit 93b9968eea on Dec 22, 2021

PastaPastaPasta referenced this in commit f80ac36acb on Dec 22, 2021

DrahtBot locked this on Feb 15, 2022

build: fix libevent linking errors for bench-only builds #18377

Conflicts

Gitian builds

Gitian builds