scripts: add MACHO tests to test-security-check.py #18415

1. 
   fanquake commented at 4:47 am on March 24, 2020: member

   Adds tests for the MACHO checks in security-check.py: https://github.com/bitcoin/bitcoin/blob/ac579ada7e83a1b8100d611412f9ede885a4e522/contrib/devtools/security-check.py#L212-L214

   I’m planning on following up with more checks in security-check.py, and corresponding tests in test-security-check.py.

   Note that you’ll probably have to be on macOS to run them. You can run just this suite with python3 test-security-check.py TestSecurityChecks.test_MACHO.

2. fanquake added the label macOS on Mar 24, 2020
3. fanquake added the label Scripts and tools on Mar 24, 2020
4. MarcoFalke added the label Needs gitian build on Mar 24, 2020
5. 
   practicalswift commented at 12:43 pm on March 24, 2020: contributor

   Concept ACK: mitigations are important.
6. 
   hebasto commented at 4:40 pm on March 24, 2020: member

   Concept ACK.
7. 
   laanwj commented at 1:35 pm on March 25, 2020: member

   Concept + code review ACK

   Cannot test it though due to lack of MacOS

   Is this test called anywhere in Travis?

8. scripts: add MACHO tests to test-security-check.py 1a4e9f32ef
9. scripts: add MACHO NX check to security-check.py edaca2dd12
10. scripts: rename test_64bit_PE to test_PE 7142d50ac3
11. fanquake force-pushed on Mar 26, 2020
12. 
    fanquake commented at 3:41 am on March 26, 2020: member

    Is this test called anywhere in Travis?

    No, however I’ll open a followup to address this.

    I’ve added an additional security check here for NX on macOS, and renamed the PE test.

13. 
    DrahtBot commented at 7:50 am on March 26, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18295 (build: teach ld64 to actually insert MH_BINDATLOAD by fanquake)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

14. DrahtBot removed the label Needs gitian build on Mar 26, 2020
15. MarcoFalke deleted a comment on Mar 26, 2020
16. MarcoFalke added the label Needs gitian build on Mar 26, 2020
17. 
    laanwj commented at 8:50 am on March 27, 2020: member

    No, however I’ll open a followup to address this.

    Thanks!

18. 
    DrahtBot commented at 6:43 pm on March 27, 2020: member

    Gitian builds

    File	commit 7f9dedb22dcd9550ca525c0e35fec38b2d59e029(master)	commit c01adcacecc89bfee25d266fca97cb828fa7e057(master and this pull)
    bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	8aa34845a916014d...	9080c7dee6c0df17...
    bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	0fb3dd16db30ea00...	4c30e622a3ee498e...
    bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	797f185a8e62f6fe...	62b24fe0ac227a21...
    bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	871094b510da0ac7...	b2e13cf60d248b50...
    bitcoin-0.19.99-osx-unsigned.dmg	a159b1b99b607907...	b0060ea83e0ea07e...
    bitcoin-0.19.99-osx64.tar.gz	1fb6370553afcb22...	e01036bc9636ebb1...
    bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	0b86916151aea5a3...	1daf891919cd77a5...
    bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	4efb63771485711b...	a40a5fc7f06388e9...
    bitcoin-0.19.99-win64-debug.zip	dd825e6168d39c90...	622c2e7882fc60c7...
    bitcoin-0.19.99-win64-setup-unsigned.exe	d1f790ad8c257da0...	f289b7f70d3657bb...
    bitcoin-0.19.99-win64.zip	49dc4119ae2a01c4...	bdc4d7743c92ae4f...
    bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	2a144f502390b6e3...	0cd4bb03220eb6e7...
    bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	af6a5d2d555569a4...	d6fa896b34b5389c...
    bitcoin-0.19.99.tar.gz	900859565b6ee1fe...	1f94f9c71441b550...
    bitcoin-core-linux-0.20-res.yml	70c720b679a19c93...	98a710e3c51cf1e6...
    bitcoin-core-osx-0.20-res.yml	5766a2f7c8d8547a...	7a87a656e85222a1...
    bitcoin-core-win-0.20-res.yml	a95a890f0d0cb882...	a83824338d4a1439...
    linux-build.log	8510c43606df6b17...	7a34d3f71bbe2996...
    osx-build.log	b2fce58471126628...	c084b66187ad9f63...
    win-build.log	630e3d23ee0657f4...	ec2ca979e5f8bbe8...
    bitcoin-core-linux-0.20-res.yml.diff		f1a8c937ffd729f9...
    bitcoin-core-osx-0.20-res.yml.diff		8a6661090f1a1a11...
    bitcoin-core-win-0.20-res.yml.diff		4e49583dddda2e6f...
    linux-build.log.diff		61d8f304c500e586...
    osx-build.log.diff		98d6d7897f6a6e48...
    win-build.log.diff		9f852e0702e2157f...

19. DrahtBot removed the label Needs gitian build on Mar 27, 2020
20. 
    laanwj commented at 10:47 am on March 28, 2020: member

    ACK 7142d50ac33e0ad7d24e49e04c1fc7e3e769ed46
21. laanwj merged this on Mar 28, 2020
22. laanwj closed this on Mar 28, 2020

    ---

23. fanquake deleted the branch on Mar 29, 2020
24. laanwj referenced this in commit f658c15bb9 on Jun 16, 2020
25. DrahtBot locked this on Feb 15, 2022

Contributors
fanquake practicalswift hebasto laanwj DrahtBot

Labels
macOS Scripts and tools