ci: Use Homebrew addon on native macOS #18438

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20200326-brew-addon changing 3 files +14 −23
  1. hebasto commented at 10:30 am on March 26, 2020: member

    Recently almost every macOS image update on Travis breaks our builds:

    This PR:

    • fixes the error caused by the recent update from 10.14.4 (18E226) to 10.14.6 (18G3020) on March 25
    • leverages Homebrew addon to install packages

    Homebrew is not told to install automake and pkg-config packages, as the docs states that they are pre-installed:

    • automake 1.16.1
    • pkg-config 0.29.2
  2. fanquake added the label Tests on Mar 26, 2020
  3. hebasto renamed this:
    [WIP] ci: Use Homebrew addon on native macOS
    ci: Use Homebrew addon on native macOS
    on Mar 26, 2020
  4. in ci/test/04_install.sh:19 in ae9b1e2faa outdated
    18@@ -19,18 +19,6 @@ if [ "$TRAVIS_OS_NAME" == "osx" ]; then
    19   git reset --hard origin/master
    


    MarcoFalke commented at 12:43 pm on March 26, 2020:
    Why is this needed?

    hebasto commented at 12:58 pm on March 26, 2020:
    No need. Removed.
  5. ci: Fix brew in Travis 596c627a1e
  6. ci: Use Homebrew addon on native macOS
    Also the macOS image has been updated.
    25c8b73656
  7. hebasto force-pushed on Mar 26, 2020
  8. hebasto commented at 1:02 pm on March 26, 2020: member

    Updated ae9b1e2faa960293345513c0b86666c26a113730 -> 25c8b73656c90f7b78a90f25c5bcc308f8b7c598 (pr18438.01 -> pr18438.02, diff):

  9. fanquake commented at 1:05 pm on March 26, 2020: member
    Concept ACK. Thanks for following up with this.
  10. MarcoFalke merged this on Mar 26, 2020
  11. MarcoFalke closed this on Mar 26, 2020

  12. MarcoFalke commented at 1:13 pm on March 26, 2020: member

    Seems to pick up everything correctly (wallet, ccache, qt):

     0Options used to compile and link:
     1
     2  with wallet   = yes
     3
     4  with gui / qt = yes
     5
     6    with qr     = yes
     7
     8  with zmq      = yes
     9
    10  with test     = yes
    11
    12    with prop   = no
    13
    14    with fuzz   = no
    15
    16  with bench    = yes
    17
    18  with upnp     = yes
    19
    20  use asm       = yes
    21
    22  sanitizers    = 
    23
    24  debug enabled = no
    25
    26  gprof enabled = no
    27
    28  werror        = yes
    29
    30  target os     = darwin
    31
    32  build os      = darwin
    33
    34  CC            = /usr/local/bin/ccache gcc
    35
    36  CFLAGS        = -g -O2
    37
    38  CPPFLAGS      =   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -I/usr/local/opt/berkeley-db@4/include -DMAC_OSX -DOBJC_OLD_DISPATCH_PROTOTYPES=0
    39
    40  CXX           = /usr/local/bin/ccache g++ -std=c++11
    41
    42  CXXFLAGS      =   -Wstack-protector -fstack-protector-all  -Wall -Wextra -Wformat -Wvla -Wswitch -Wformat-security -Wthread-safety-analysis -Wrange-loop-analysis -Wredundant-decls -Wunused-variable -Wdate-time  -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register -Wno-implicit-fallthrough  -Werror=vla -Werror=switch -Werror=thread-safety-analysis -Werror=unused-variable -Werror=date-time -Werror=return-type  -g -O2 -fvisibility=hidden
    43
    44  LDFLAGS       = -pthread  -Wl,-bind_at_load   -Wl,-headerpad_max_install_names -Wl,-dead_strip -Wl,-dead_strip_dylibs
    45
    46  ARFLAGS       = cr
    
  13. hebasto deleted the branch on Mar 26, 2020
  14. MarcoFalke referenced this in commit 90b5fc9ce4 on Jul 14, 2020
  15. sidhujag referenced this in commit 0842b3112b on Jul 14, 2020
  16. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me