ci: Use Homebrew addon on native macOS #18438

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20200326-brew-addon changing 3 files +14 −23

hebasto commented at 10:30 AM on March 26, 2020: member
Recently almost every macOS image update on Travis breaks our builds:
- #17848
- #18436
This PR:
- fixes the error caused by the recent update from 10.14.4 (18E226) to 10.14.6 (18G3020) on March 25
- leverages Homebrew addon to install packages
Homebrew is not told to install automake and pkg-config packages, as the docs states that they are pre-installed:
automake 1.16.1

pkg-config 0.29.2
fanquake added the label Tests on Mar 26, 2020
hebasto renamed this:
~~[WIP] ci: Use Homebrew addon on native macOS~~
ci: Use Homebrew addon on native macOS
on Mar 26, 2020
in ci/test/04_install.sh:19 in ae9b1e2faa outdated
```
  18 | @@ -19,18 +19,6 @@ if [ "$TRAVIS_OS_NAME" == "osx" ]; then
  19 |    git reset --hard origin/master
```
MarcoFalke commented at 12:43 PM on March 26, 2020:

Why is this needed?

hebasto commented at 12:58 PM on March 26, 2020:

No need. Removed.
ci: Fix brew in Travis 596c627a1e
ci: Use Homebrew addon on native macOS
Also the macOS image has been updated.
25c8b73656
hebasto force-pushed on Mar 26, 2020
hebasto commented at 1:02 PM on March 26, 2020: member
Updated ae9b1e2faa960293345513c0b86666c26a113730 -> 25c8b73656c90f7b78a90f25c5bcc308f8b7c598 (pr18438.01 -> pr18438.02, diff):
- @MarcoFalke's comment addressed
fanquake commented at 1:05 PM on March 26, 2020: member

Concept ACK. Thanks for following up with this.
MarcoFalke merged this on Mar 26, 2020
MarcoFalke closed this on Mar 26, 2020

MarcoFalke commented at 1:13 PM on March 26, 2020: member

Seems to pick up everything correctly (wallet, ccache, qt):

Options used to compile and link:

  with wallet   = yes

  with gui / qt = yes

    with qr     = yes

  with zmq      = yes

  with test     = yes

    with prop   = no

    with fuzz   = no

  with bench    = yes

  with upnp     = yes

  use asm       = yes

  sanitizers    = 

  debug enabled = no

  gprof enabled = no

  werror        = yes

  target os     = darwin

  build os      = darwin

  CC            = /usr/local/bin/ccache gcc

  CFLAGS        = -g -O2

  CPPFLAGS      =   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Qunused-arguments  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -I/usr/local/opt/berkeley-db@4/include -DMAC_OSX -DOBJC_OLD_DISPATCH_PROTOTYPES=0

  CXX           = /usr/local/bin/ccache g++ -std=c++11

  CXXFLAGS      =   -Wstack-protector -fstack-protector-all  -Wall -Wextra -Wformat -Wvla -Wswitch -Wformat-security -Wthread-safety-analysis -Wrange-loop-analysis -Wredundant-decls -Wunused-variable -Wdate-time  -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register -Wno-implicit-fallthrough  -Werror=vla -Werror=switch -Werror=thread-safety-analysis -Werror=unused-variable -Werror=date-time -Werror=return-type  -g -O2 -fvisibility=hidden

  LDFLAGS       = -pthread  -Wl,-bind_at_load   -Wl,-headerpad_max_install_names -Wl,-dead_strip -Wl,-dead_strip_dylibs

  ARFLAGS       = cr

hebasto deleted the branch on Mar 26, 2020
MarcoFalke referenced this in commit 90b5fc9ce4 on Jul 14, 2020
sidhujag referenced this in commit 0842b3112b on Jul 14, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#17848 travis: macos runs on python2.7 #18436 ci: Fix brew in Travis #19495 ci: Disable macOS functional tests on forked repos to avoid timeouts