Based on #18338, only last commit matters. Quoting the test description:
0// Test UnregisterSharedValidationInterface ensuring that if interface is
1// unregistered during the middle of a callback, interface is destroyed as soon
2// as callback returns.
All credits to ryanofsky.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
The previous code for MainSignalsInstance::Clear would decrement the reference
count of every interface, including ones that were already Unregister()ed but
still being executed.
Now based on #18551, applied the following change to the test to account for @sipa fix (this now fails in master):
0@@ -397,6 +397,7 @@ BOOST_AUTO_TEST_CASE(release_shared)
1 BOOST_CHECK(!test_interface);
2 BOOST_CHECK_EQUAL(state, CALLED);
3 state = UNREGISTERED;
4+ UnregisterAllValidationInterfaces();
5 unregistered.set_value(true);
6 BOOST_CHECK(destroyed.get_future().get());
7 BOOST_CHECK_EQUAL(state, DESTROYED);
OSError: [WinError 10048] Only one usage of each socket address (protocol/network address/port) is normally permitted, restarted.
🐙 This pull request conflicts with the target branch and needs rebase.
