This was added in 386efb7695debaf5f0f328a2e4c9abc342161665 to address spammy Clang warnings when building with ccache.
The issue was addressed in ccache 3.2, and from a look at most major distros, it's only Debian Jessie that has a version of ccache older than that (3.1).
Therefore I think it's acceptable to drop this workaround, and re-enable warnings for unused driver arguments (when compiling using Clang and ccache).
This was added in 386efb7695debaf5f0f328a2e4c9abc342161665 to
address spammy Clang warnings when building with ccache.
The issue was addressed in ccache 3.2
(https://bugzilla.samba.org/show_bug.cgi?id=8118, Nov 2014),
and from a look at all major distros, it's only Debian Jessie
that has a version of ccache older than that (3.1).
Therefore I think it's acceptable to drop this workaround, and
re-enable warnings for unused driver arguments (when compiling
using Clang).
Concept ACK
Thanks for cleaning up!
<!--a722867cd34abeea1fadc8d60700f111-->
| File | commit adac12ae73e896e405e75b02a0a49c575d115b6e<br>(master) | commit a309ee60eaa9cac91a85a1fe03bb7e2977f5a2bf<br>(master and this pull) |
|---|---|---|
| bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz | d5b53a3f89f72ead... |
456c6b38bccd15de... |
| bitcoin-0.19.99-aarch64-linux-gnu.tar.gz | 067812d8fbd9918e... |
c9912cfc75aae509... |
| bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz | 8be7ab33ba6e6075... |
927185dfdf398f01... |
| bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz | 194ab99a0758ca25... |
ead7a87d54202249... |
| bitcoin-0.19.99-osx-unsigned.dmg | e076c26306f27f2c... |
8c2e8003737fcb84... |
| bitcoin-0.19.99-osx64.tar.gz | cbc6f79d1cd0fe5b... |
b08e8aa424981a8a... |
| bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz | cf5a067865c9558e... |
e6ba44bdf9318a5d... |
| bitcoin-0.19.99-riscv64-linux-gnu.tar.gz | fd751d3483c555e7... |
45491cf2bffef95c... |
| bitcoin-0.19.99-win64-debug.zip | 37604981ab8d9fde... |
2e869426cfd25cef... |
| bitcoin-0.19.99-win64-setup-unsigned.exe | ddb2a875e5748c9b... |
a7015f91d6fbe082... |
| bitcoin-0.19.99-win64.zip | fe934b412baf6fb3... |
b83bf9dc27c91351... |
| bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz | 0d4c783eb986d57b... |
5fee80283d704cd5... |
| bitcoin-0.19.99-x86_64-linux-gnu.tar.gz | 067d79d34ba518b5... |
3f5a6e07616f8055... |
| bitcoin-0.19.99.tar.gz | 59e74c33a2c18358... |
21488168441cdc28... |
| bitcoin-core-linux-0.20-res.yml | 100f56d6448f4b18... |
12dfd443304cffb7... |
| bitcoin-core-osx-0.20-res.yml | 0714155380d848a8... |
b951a13af418ea8d... |
| bitcoin-core-win-0.20-res.yml | 1ef3d9373bdb5c0e... |
bfa3a469f43be5fe... |
| linux-build.log | 382a1ae618392852... |
a952c21cc5c6ca9d... |
| osx-build.log | a02b5e5ada7fbc28... |
826112ec65871bd3... |
| win-build.log | 5ba854bca82ac9b9... |
f69d7df8d78bbf99... |
| bitcoin-core-linux-0.20-res.yml.diff | 3c473283aa38dd15... |
|
| bitcoin-core-osx-0.20-res.yml.diff | 47528d87816c704c... |
|
| bitcoin-core-win-0.20-res.yml.diff | 09711d4599a2f94f... |
|
| linux-build.log.diff | 4b9da86097cd5513... |
|
| osx-build.log.diff | 1f31dcb56b1fc9aa... |
|
| win-build.log.diff | 2889a982136d1ad9... |
ACK a029805f57fa9a4ab9867c0d1e865675d57537c7.
Both master and master+PR produce the same two warnings:
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
clang: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
that are not related to ccache.
utACK a029805f57fa9a4ab9867c0d1e865675d57537c7