wallet: Abort when assumption fails in debug mode #18555

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2004-walletAssumeAbortDebug changing 3 files +57 −0

MarcoFalke commented at 11:28 AM on April 7, 2020: member

First commit stolen from #16136
Second commit looks failing like this:

2020-04-07T11:26:54Z [default wallet] DelAddressBook called with IsMine address, NOT SUPPORTED. Please report this bug! https://github.com/bitcoin/bitcoin/issues
wallet/wallet.cpp:3227: DelAddressBook: ASSUME(false) failed. You may report this issue here: https://github.com/bitcoin/bitcoin/issues
Aborted (core dumped)

Add ASSUME(expr). Set -ABORT_ON_ASSUME_FAIL when configured with --enable-debug or --enable-fuzz. 4a288abc41
wallet: Abort when assumption fails in debug mode fa5166b61a
fanquake added the label Wallet on Apr 7, 2020
practicalswift commented at 12:11 PM on April 7, 2020: contributor

Concept ACK

Thanks for picking this up! :)
practicalswift commented at 3:37 PM on April 8, 2020: contributor

ACK fa5166b61adde799a903635fc876d4859d73d628 -- patch looks correct
MarcoFalke commented at 11:54 PM on April 12, 2020: member

This should probably use CHECK_NONFATAL
MarcoFalke closed this on Apr 12, 2020
MarcoFalke deleted the branch on Apr 12, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

MarcoFalke

practicalswift

Labels

Wallet

Linked (view graph)

#16136 Add an optional extra level of checking: ASSUME(...) - an opt-in side-effect safe assert(...)