URI handling broken on Windows ? #1877

issue gavinandresen opened this issue on September 27, 2012
  1. gavinandresen commented at 9:05 PM on September 27, 2012: contributor

    See https://bitcointalk.org/index.php?topic=110243 for multiple reports of URI handling not working.

  2. laanwj commented at 5:45 AM on September 28, 2012: member

    @diapolo can you please check?

  3. Diapolo commented at 6:27 AM on September 28, 2012: none

    Yeah, I'm going to do some tests!

    Tests were run with v0.7.0-beta (last official release): Running instance and clicking an invalid Bitcoin-URI: passed (tray-notification is shown) Running instance and clicking a valid Bitcoin-URI: passed (client is shown / address and amount is entered) Starting instance by clicking an invalid Bitcoin-URI: passed (tray-notification is shown) Starting instance by clicking a valid Bitcoin-URI: passed (client starts / address and amount is entered)

    Looking good to me, I didn't yet read the thread, will do that now.

  4. Diapolo commented at 11:07 AM on September 28, 2012: none

    It could be we have a problem with: https://github.com/bitcoin/bitcoin/blob/master/share/setup.nsi#L104

    A user on the forum reports this as his entry in the registry: "C:\Program Files (x86)\Bitcoin\bitcoin-qt.exe" "$1", wheras I have "C:\Program Files (x86)\Bitcoin\bitcoin-qt.exe" "%1" (which I setup for myself)

  5. Diapolo commented at 10:23 AM on September 29, 2012: none

    I'm now sure that we use a wrong character in the setup.nsi file, it needs to write "%1" into the registry. But I'm not sure if this is also valid for Windows XP...

  6. gavinandresen closed this on Oct 22, 2012

  7. gavinandresen referenced this in commit 135bee074d on Dec 10, 2012
  8. KolbyML referenced this in commit a59e8273fb on Dec 5, 2020
  9. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me