build: enable -Werror=gnu #18887

1. 
   vasild commented at 12:51 pm on May 5, 2020: member

   Stop the build if a warning is emitted due to -Wgnu and --enable-werror has been used. As usual - this would help notice such a warning that is about to be introduced in new code.

   This is a followup to #18088 build: ensure we aren’t using GNU extensions

2. build: enable -Werror=gnu

   Stop the build if a warning is emitted due to `-Wgnu` and
   `--enable-werror` has been used. As usual - this would help notice such
   a warning that is about to be introduced in new code.
   
   This is a followup to
   https://github.com/bitcoin/bitcoin/pull/18088
   build: ensure we aren't using GNU extensions

   a30b0a24e9
3. fanquake added the label Build system on May 5, 2020
4. 
   MarcoFalke commented at 1:02 pm on May 5, 2020: member

   Just to clarify, this is also going to enable the error for all dependencies we build? qt, boost, leveldb, …
5. 
   vasild commented at 1:25 pm on May 5, 2020: member

   Just to clarify, this is also going to enable the error for all dependencies we build? qt, boost, leveldb, …

   Yes, if --enable-werror is used.

   #18750 is related - it would give us more flexibility.

6. 
   DrahtBot commented at 6:10 pm on May 5, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18857 (build: avoid repetitions when enabling warnings in configure.ac by vasild)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   laanwj commented at 10:33 am on May 6, 2020: member

   Just to clarify, this is also going to enable the error for all dependencies we build? qt, boost, leveldb, …

   Yes, though only for the headers.

   I think this is okay. --enable-werror is a developer option, it’s not supposed to be enabled by people that just want to build from source.

8. 
   practicalswift commented at 2:03 pm on May 6, 2020: contributor

   ACK a30b0a24e97eae7f6d1428c5bf339a579872f28e
9. 
   Empact commented at 9:05 pm on May 6, 2020: member

   ACK https://github.com/bitcoin/bitcoin/pull/18887/commits/a30b0a24e97eae7f6d1428c5bf339a579872f28e
10. laanwj merged this on May 13, 2020
11. laanwj closed this on May 13, 2020

    ---

12. sidhujag referenced this in commit ca5297cd76 on May 14, 2020
13. vasild deleted the branch on May 14, 2020
14. PastaPastaPasta referenced this in commit 4085118d0b on Jun 27, 2021
15. PastaPastaPasta referenced this in commit 7e392a9b4a on Jun 28, 2021
16. PastaPastaPasta referenced this in commit 483c108cff on Jun 29, 2021
17. PastaPastaPasta referenced this in commit 9802d1b7f1 on Jul 1, 2021
18. PastaPastaPasta referenced this in commit 7cd14fe0a4 on Jul 1, 2021
19. PastaPastaPasta referenced this in commit e30e39c0aa on Jul 14, 2021
20. PastaPastaPasta referenced this in commit 35e1a2333e on Sep 17, 2021
21. DrahtBot locked this on Feb 15, 2022

Contributors
vasild MarcoFalke DrahtBot laanwj practicalswift Empact

Labels
Build system