p2p: add MAX_FEELER_CONNECTIONS constant #18910

1. 
   fanquake commented at 1:30 AM on May 8, 2020: member

   Extracted from #16003.

2. fanquake added the label P2P on May 8, 2020
3. hebasto approved
4. 
   hebasto commented at 5:42 AM on May 8, 2020: member

   ACK 37eb3116bf6d97c4787ba3b7ee29dc96fa742d99

   nit: it seems GH does not recognize https://github.com/tryphe as an author. Maybe because of different emails:

   $ git log --no-merges | grep -A 3 tryphe
   Author: tryphe <tryphe@noreply.github.com>
   Date:   Wed May 8 04:34:01 2019 -0400
   
       p2p: add MAX_FEELER_CONNECTIONS constant
   --
   Author: tryphe <tryphe@users.noreply.github.com>
   Date:   Sat May 4 22:01:51 2019 -0400
   
       remove old bootstrap relevant code
   

5. 
   naumenkogs commented at 1:27 PM on May 8, 2020: member

   utACK 37eb311. Went through the code to check that we do support >1 feelers.

6. fanquake requested review from ajtowns on May 8, 2020
7. 
   practicalswift commented at 6:11 AM on May 9, 2020: contributor

   ACK 37eb3116bf6d97c4787ba3b7ee29dc96fa742d99

8. 
   instagibbs commented at 6:39 PM on May 9, 2020: member

   Might be worth including the constant here since I think this is the only other place using the now-unnamed constant: src/test/denialofservice_tests.cpp:158: options.nMaxFeeler = 1;

   ACK https://github.com/bitcoin/bitcoin/pull/18910/commits/37eb3116bf6d97c4787ba3b7ee29dc96fa742d99

9. p2p: add MAX_FEELER_CONNECTIONS constant 25d8264c95
10. test: use p2p constants in denial of service tests e3047edfb6
11. fanquake force-pushed on May 12, 2020
12. 
    fanquake commented at 9:31 AM on May 12, 2020: member

    Might be worth including the constant here since I think this is the only other place using the now-unnamed constant:

    Added an additional commit to replace that and a couple other constants.

13. 
    naumenkogs commented at 11:37 AM on May 12, 2020: member

    utACK e3047ed

14. fanquake merged this on May 12, 2020
15. fanquake closed this on May 12, 2020

    ---

16. fanquake deleted the branch on May 12, 2020
17. sidhujag referenced this in commit f4d69f72b5 on May 12, 2020
18. Fabcien referenced this in commit 2af1d6f3b1 on Jan 28, 2021
19. DrahtBot locked this on Feb 15, 2022

Review Requested
ajtowns