build: don't pass -w when building for Windows #18928

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:dont_try_suppress_all_warnings_win changing 1 files +0 −3
  1. fanquake commented at 11:37 AM on May 10, 2020: member

    This has been around since the introduction of autotools. However at this point I'm not sure we'd ever want to suppress all warnings when performing a build, and given that CXX FLAGS will have been overriden when cross-compiling for Windows (using depends), this would rarely, if-ever be used anyways.

    From https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html:

    -w

    Inhibit all warning messages.
  2. build: don't pass -w when building for Windows
    This has been around since the introduction of autotools. However at
    this point I'm not sure we'd every want to suppress all warnings when
    performing a build, and given that CXX FLAGS will have been overriden
    when cross-compiling for Windows (using depends), this would rarely,
    if-ever be used anyways.
    
    From https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html:
    -w
    
        Inhibit all warning messages.
    89fea68ffd
  3. fanquake added the label Windows on May 10, 2020
  4. fanquake added the label Build system on May 10, 2020
  5. MarcoFalke added the label Needs Guix build on May 10, 2020
  6. MarcoFalke added the label Needs gitian build on May 10, 2020
  7. DrahtBot commented at 1:35 PM on May 10, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15704 (Move Win32 defines to configure.ac to ensure they are globally defined by luke-jr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. hebasto approved
  9. hebasto commented at 2:10 PM on May 10, 2020: member

    ACK 89fea68ffdbd97394d891177e664f896b3e7d1e6

  10. DrahtBot commented at 9:50 AM on May 11, 2020: member

    <!--9cd9c72976c961c55c7acef8f6ba82cd-->

    Guix builds

    File commit 88d8b4e182bfc75e8496f7046af7aab93307b9d0<br>(master) commit ef686409e1a8a328e8b02919d63a8bd6f21c6b71<br>(master and this pull)
    *-aarch64-linux-gnu-debug.tar.gz 36e648159cff5ed6... 8c8444d6ada9113a...
    *-aarch64-linux-gnu.tar.gz d20bcc0bd9c3f695... 914692ab6ac7f42d...
    *-arm-linux-gnueabihf-debug.tar.gz 03baae04848b0935... 1e15ce5fac3883f1...
    *-arm-linux-gnueabihf.tar.gz d3d05ce4790dc27c... aebd11df1a072172...
    *-riscv64-linux-gnu-debug.tar.gz 147cc963e2e042d5... 5a3c7283304f4c58...
    *-riscv64-linux-gnu.tar.gz 19764893c2f77bc2... 14f0b35de35f9df3...
    *-win-unsigned.tar.gz 07ed9dbbe1c6b8aa... c0dd318bc3f87591...
    *-win64-debug.zip 71d5562716683571... 18f6ab752c5093e7...
    *-win64-setup-unsigned.exe 2b42fe78843dcc49... 3c002d3a0a8c161f...
    *-win64.zip dbc8acb3578c7889... 5d7edf079a14ce26...
    *-x86_64-linux-gnu-debug.tar.gz 7cd817b3e658b98e... 66811a50c367a3d2...
    *-x86_64-linux-gnu.tar.gz 713be37cf10bfee7... d42154e94bd8ebcb...
    *.tar.gz c84b1941b1714f4f... 754245b7364842f4...
    guix_build.log a30edfe7b4a55f51... 913fd47b7dcbda07...
    guix_build.log.diff a9432046c12da044...
  11. DrahtBot removed the label Needs Guix build on May 11, 2020
  12. fanquake merged this on May 12, 2020
  13. fanquake closed this on May 12, 2020

  14. fanquake deleted the branch on May 12, 2020
  15. MarcoFalke removed the label Needs gitian build on May 12, 2020
  16. DrahtBot commented at 1:08 PM on May 12, 2020: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds

    File commit f71a3a8829746cb17fc42c7475cf03229ad6c08e<br>(master) commit 42af9868d1e7b41da9f63eee76ce514c41fb7b92<br>(master and this pull)
    bitcoin-core-linux-0.21-res.yml 5d31e82cb026651a... 795aa1cb351d3b40...
    bitcoin-core-osx-0.21-res.yml 2cff1caff01e1875... 4e0c8f1ae4d0a8b5...
    bitcoin-core-win-0.21-res.yml 306cc058bdb82254... ef569cb667a7c137...
    *-aarch64-linux-gnu-debug.tar.gz 710502672c9fee25... 75f153bba4b7f526...
    *-aarch64-linux-gnu.tar.gz 98357bce07b860f6... 24cedfd7a3c064d5...
    *-arm-linux-gnueabihf-debug.tar.gz 6f898a3628b604dc... 6a3cd52b739f09bb...
    *-arm-linux-gnueabihf.tar.gz c9b52d2251d5f872... f8f093b23cb3797e...
    *-osx-unsigned.dmg 0e2b801761edec6d... 364c5e9f869aed2a...
    *-osx64.tar.gz 1875278445d33964... 7a5ef72228069b1d...
    *-riscv64-linux-gnu-debug.tar.gz 2586a7823e2668e3... 5d24ac6cf9391809...
    *-riscv64-linux-gnu.tar.gz 3e46919906b9fdd7... 9f9fb8ef86a68344...
    *-win64-debug.zip 5ebc45604d4c9810... d67f5fe071293b23...
    *-win64-setup-unsigned.exe 70493ad2a4be403b... 982b9426a9525428...
    *-win64.zip c7ac6a6f297a3d36... 3ec99f39651a3e27...
    *-x86_64-linux-gnu-debug.tar.gz 534e9f20edf07c63... de36cb190fa66723...
    *-x86_64-linux-gnu.tar.gz 9bf3ac5e424a313c... af18121f89fe927a...
    *.tar.gz 63c224764a4d2961... e2b28b9b68b0ff75...
    linux-build.log 5c4762071c45cdfd... 539efa3994cf4008...
    osx-build.log 48038fb52d3c17f4... 38f934261c9716e1...
    win-build.log cc3de8d8a2bc270f... e35abb1f976d08fa...
    bitcoin-core-linux-0.21-res.yml.diff 9a1fc07806265660...
    bitcoin-core-osx-0.21-res.yml.diff 90b8704828ed6da8...
    bitcoin-core-win-0.21-res.yml.diff d912594c6806a8ca...
    linux-build.log.diff 72f7c4dadc6b69e0...
    osx-build.log.diff 96b3eada50304c26...
    win-build.log.diff f197ba67512e4654...
  17. sidhujag referenced this in commit 46c31fc1e4 on May 12, 2020
  18. zkbot referenced this in commit 372f695d4d on Jun 5, 2021
  19. jamescowens referenced this in commit 005276d898 on Jun 27, 2021
  20. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 03:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me