Instruct the linker to set the major & minor subsystem versions in the PE header to 6 & 1 (NT 6.1 which corresponds to Windows 7). Similar to the behaviour on macOS, the binary will now refuse to run on unsupported versions of Windows, which, for us, is XP & Vista.
589@@ -590,6 +590,10 @@ case $host in
590 archive_cmds_CXX="\$CC -shared \$libobjs \$deplibs \$compiler_flags -static -o \$output_objdir/\$soname \${wl}--enable-auto-image-base -Xlinker --out-implib -Xlinker \$lib"
591 postdeps_CXX=
592
593+ dnl We require at least Windows 7 (NT 6.1)
594+ AX_CHECK_LINK_FLAG([[-Wl,--major-subsystem-version -Wl,6]], [LDFLAGS="$LDFLAGS -Wl,--major-subsystem-version -Wl,6"],, [[$LDFLAG_WERROR]])
Instruct the linker to set the major & minor subsystem versions in the PE
header to 6 & 1 (NT 6.1 which corresponds to Windows 7). Similar to
macOS, the binary will now refuse to run on unsupported versions of
Windows.
the binary will now refuse to run on unsupported versions of Windows, which, for us, is XP & Vista
Concpet ACK
Seems like reasonable timing though I have no idea how many users this will affect and regardless it may be in the best interests of that small group of users anyway.
If in another 6 months time (at the 0.21 release), there are a significant number of users who can now no-longer run Bitcoin Core, because (against our suggestion) they were running it on Windows XP or Vista, we can re-evaluate this change and likely our backwards compatibility requirements.