rpcpassword is deprecated and not recommended anymore. So remove it from the logs, which indicate that an rpcpassword should be set and cause confusion. See #18998.
log: Remove "No rpcpassword set" from logs #18999
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2005-logRpcPassword changing 1 files +1 −1-
MarcoFalke commented at 4:43 PM on May 17, 2020: member
-
log: Remove "No rpcpassword set" from logs fa243be1dc
- MarcoFalke renamed this:
2005 log rpc password
log: Remove "No rpcpassword set" from logs
on May 17, 2020 - Viral approved
- DrahtBot added the label RPC/REST/ZMQ on May 17, 2020
- DrahtBot added the label Utils/log/libs on May 17, 2020
- kristapsk approved
-
kristapsk commented at 6:52 PM on May 17, 2020: contributor
ACK fa402ae92ca79177d6e20a22251b8b47fd17b5e3
-
elichai commented at 9:20 AM on May 18, 2020: contributor
Code review ACK fa402ae92ca79177d6e20a22251b8b47fd17b5e3
-
practicalswift commented at 11:29 AM on May 18, 2020: contributor
Concept ACK, but I suggest remove this
LogPrintf(orLogPrint(DEBUG_CATEGORY, …):ing it instead):if (gArgs.GetArg("-rpcpassword", "") == "") { LogPrintf("No rpcpassword set - using random cookie authentication.\n");Generally I think it is bad usability to do "you're using the defaults - everything is normal" logging. It is when not using the defaults the user may want to be informed about doing so :)
-
MarcoFalke commented at 11:44 AM on May 18, 2020: member
@practicalswift there is not category for init messages right now and init messages are logged unconditionally. If this should be changed, then a separate pull request or a brainstorming issue seems appropriate, but it seems out of scope of this pull request.
- MarcoFalke force-pushed on May 18, 2020
-
MarcoFalke commented at 1:23 PM on May 18, 2020: member
Apologies to reviewers, but I have decided to drop the second commit and remove that InitError as part of a separate bugfix: #19006
- Viral approved
- Viral approved
-
elichai commented at 3:11 PM on May 18, 2020: contributor
Re Code Review ACK (Checked the diff) fa243be1dc49385fff847f8a784c7a9c9f07c939
- ryanofsky approved
-
ryanofsky commented at 4:10 PM on May 18, 2020: member
Code review ACK fa243be1dc49385fff847f8a784c7a9c9f07c939. New log message makes more sense
- fanquake merged this on May 19, 2020
- fanquake closed this on May 19, 2020
- MarcoFalke deleted the branch on May 19, 2020
- Fabcien referenced this in commit ba4e8e9d97 on Feb 3, 2021
- PastaPastaPasta referenced this in commit 03bb24fabe on Jun 27, 2021
- PastaPastaPasta referenced this in commit c2b0e19766 on Jun 28, 2021
- PastaPastaPasta referenced this in commit 057a07810f on Jun 29, 2021
- PastaPastaPasta referenced this in commit 6d2d64496e on Jul 1, 2021
- PastaPastaPasta referenced this in commit 722acb1bbe on Jul 1, 2021
- PastaPastaPasta referenced this in commit 16b4cd935d on Jul 14, 2021
- PastaPastaPasta referenced this in commit 1ac86caa01 on Jul 15, 2021
- DrahtBot locked this on Feb 15, 2022
