doc: Add link to Visual Studio build readme #19061

pull maitrebitcoin wants to merge 1 commits into bitcoin:master from maitrebitcoin:master changing 1 files +1 −1

maitrebitcoin commented at 6:07 AM on May 24, 2020: contributor

I have searched how to do it in this doc for some time :-( I think it might help other newbies interested in building with visual studio.
fanquake added the label Docs on May 24, 2020
in doc/build-windows.md:106 in 74c35e1db5 outdated
```
 100 | @@ -101,6 +101,10 @@ Build using:
 101 |      CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site ./configure --prefix=/
 102 |      make
 103 |  
 104 | +## Building using a native compiler tool chain such as Visual Studio
 105 | +
 106 | +Full instructions are available in [README.md](..//build_msvc/README.md).
```
MarcoFalke commented at 11:18 AM on May 24, 2020:

This is already mentioned in the bullet point in the first section

On Windows, using a native compiler tool chain such as Visual Studio.

Please just add the link there

maitrebitcoin commented at 7:56 PM on May 24, 2020:

Yes this is better. new commit added

in doc/build-windows.md:12 in 9c0bf9abc0 outdated

   8 | @@ -9,7 +9,7 @@ The options known to work for building Bitcoin Core on Windows are:
   9 |  and is the platform used to build the Bitcoin Core Windows release binaries.
  10 |  * On Windows, using [Windows
  11 |  Subsystem for Linux (WSL)](https://docs.microsoft.com/windows/wsl/about) and the Mingw-w64 cross compiler tool chain.
  12 | -* On Windows, using a native compiler tool chain such as [Visual Studio](https://www.visualstudio.com).
  13 | +* On Windows, using a native compiler tool chain such as [Visual Studio](https://www.visualstudio.com). See [README.md](../build_msvc/README.md).

MarcoFalke commented at 10:07 PM on May 24, 2020:

* On Windows, using a native compiler tool chain such as [Visual Studio](https://www.visualstudio.com). See [README.md](/build_msvc/README.md).

the link can be absolute

MarcoFalke commented at 10:07 PM on May 24, 2020: member

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
hebasto commented at 6:08 AM on May 25, 2020: member

@maitrebitcoin Welcome and thank you for your contribution!

Tested a96fc40f2dc0aa9e319fbe4addee4a9240df805b, clicked the link and it works.

Mind squashing three commits into the one?

Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
maitrebitcoin commented at 8:01 PM on May 25, 2020: contributor

I tried to squash, but I'm not sure this is all OK.
fanquake commented at 4:49 AM on May 26, 2020: member

Thanks, however this still needs fixing up. When you are done squashing there should only be a single commit in this PR.

MarcoFalke commented at 10:14 AM on May 26, 2020: member

Try something like this

git reset --soft core/master
git commit -m 'doc : add link to readme.md in the first section'

laanwj renamed this:
~~doc: new section on to how to build with visual studio~~
doc: Add link to Visual Studio build readme
on May 26, 2020
doc : add link to readme.md in the first section 1c91ffefcf
maitrebitcoin force-pushed on May 27, 2020
maitrebitcoin commented at 6:05 AM on May 27, 2020: contributor

Looks like i managed to do it somehow. Thanks for the tips and your patience.
hebasto approved
hebasto commented at 6:51 AM on May 27, 2020: member

ACK 1c91ffefcf54d22f805c86318ea32d23b9d20c96, a new link works as expected :)
fanquake merged this on May 27, 2020
fanquake closed this on May 27, 2020
PastaPastaPasta referenced this in commit 754b59ecd0 on Jun 27, 2021
PastaPastaPasta referenced this in commit 337a3c75e0 on Jun 28, 2021
PastaPastaPasta referenced this in commit f0a7b778d1 on Jun 29, 2021
PastaPastaPasta referenced this in commit 3952b725f0 on Jul 1, 2021
PastaPastaPasta referenced this in commit fd0a38371d on Jul 1, 2021
PastaPastaPasta referenced this in commit 93c5ca4861 on Jul 14, 2021
PastaPastaPasta referenced this in commit ee88bd7e0f on Sep 17, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels