Remove outdated comment about DER encoding #19073

pull elichai wants to merge 1 commits into bitcoin:master from elichai:2020-05-remove-der-comment changing 1 files +1 −2

elichai commented at 5:52 PM on May 26, 2020: contributor

This comment got me confused about the status of BIP66 (Thanks jnewbery for explaining) The comment was added in: #3843 But in #5713 strict DER encoding was enforced in consensus, and is now it's buried and enforced by the height of the block here: https://github.com/bitcoin/bitcoin/blob/4af01b37d40246cd1fdb54719855927e36a36b46/src/validation.cpp#L1889

P.S. This is also quite confusing: https://github.com/bitcoin/bitcoin/blob/4af01b37d40246cd1fdb54719855927e36a36b46/src/validation.cpp#L1560-L1563 But seems to be intentional: https://github.com/bitcoin/bitcoin/blob/4af01b37d40246cd1fdb54719855927e36a36b46/src/validation.cpp#L1510-L1511
Remove outdated comment about DER encoding 4c825792dd
jnewbery commented at 6:33 PM on May 26, 2020: member

ACK
Empact commented at 6:35 PM on May 26, 2020: member

ACK
laanwj commented at 6:45 PM on May 26, 2020: member

ACK 4c825792dd9f4eaf4936c3e376ac7a5c177528e2
fanquake merged this on May 27, 2020
fanquake closed this on May 27, 2020
elichai deleted the branch on May 27, 2020
sidhujag referenced this in commit bf5ca922fd on May 27, 2020
PastaPastaPasta referenced this in commit eb91540645 on Jun 27, 2021
PastaPastaPasta referenced this in commit aaa99155ea on Jun 28, 2021
PastaPastaPasta referenced this in commit 7e867e95e1 on Jun 29, 2021
PastaPastaPasta referenced this in commit e1dc813f55 on Jul 1, 2021
PastaPastaPasta referenced this in commit c333a6fc91 on Jul 1, 2021
PastaPastaPasta referenced this in commit f3f00f446e on Jul 14, 2021
PastaPastaPasta referenced this in commit 7ac32ac79f on Jul 15, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Linked (view graph)

#3843 Fix CHECKMULTISIG mutability and remove P2SH CHECKMULTISIG # of signatures limit #5713 Implement BIP66