ci: tsan with wallet #19164

1. 
   MarcoFalke commented at 10:54 pm on June 3, 2020: member
2. fanquake added the label Tests on Jun 3, 2020
3. MarcoFalke force-pushed on Jun 3, 2020
4. 
   DrahtBot commented at 0:25 am on June 4, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #19162 (ci: tsan gui by MarcoFalke)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   practicalswift commented at 10:52 am on June 4, 2020: contributor

   Concept ACK: more TSan coverage is better :)
6. MarcoFalke force-pushed on Jun 4, 2020
7. MarcoFalke force-pushed on Jun 4, 2020
8. ci: tsan with wallet fa7e002d52
9. MarcoFalke force-pushed on Jun 4, 2020
10. 
    practicalswift commented at 7:37 am on June 5, 2020: contributor

    ACK fa7e002d520d8390f3ff4b0383cfdfc14713355d – patch looks correct and Travis is happy
11. hebasto approved
12. 
    hebasto commented at 7:44 am on June 5, 2020: member

    ACK fa7e002d520d8390f3ff4b0383cfdfc14713355d, I have reviewed the code and it looks OK, I agree it can be merged.
13. fanquake merged this on Jun 5, 2020
14. fanquake closed this on Jun 5, 2020

    ---

15. MarcoFalke deleted the branch on Jun 5, 2020
16. in test/sanitizer_suppressions/tsan:30 in fa7e002d52

    25 # deadlock (TODO fix)
    26 deadlock:CConnman::ForNode
    27+deadlock:CConnman::GetNodeStats
    28+deadlock:CChainState::ConnectTip
    29 deadlock:UpdateTip
    30+deadlock:wallet_tests::CreateWalletFromFile
    

    ---

    ---

    

    ryanofsky commented at 11:56 am on June 5, 2020:

    Thanks for this. There’s discussion about this case in https://github.com/bitcoin/bitcoin/issues/19049
17. Fabcien referenced this in commit de9e50126c on Feb 9, 2021
18. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke DrahtBot practicalswift hebasto ryanofsky

Labels
Tests