test: Do not swallow flake8 exit code #19172

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:200605-mypy changing 2 files +12 −3

hebasto commented at 6:15 AM on June 5, 2020: member
After #18210 the flake8 exit code in test/lint/lint-python.sh just not used that makes the linter broken.

This PR:
- combines exit codes of flake8 and mypy into the test/lint/lint-python.sh exit code
- documents mypy as the test dependency
DrahtBot added the label Docs on Jun 5, 2020
DrahtBot added the label Tests on Jun 5, 2020
practicalswift commented at 7:40 AM on June 5, 2020: contributor

Oh, very nice catch! Thanks for fixing.

ACK eff770fcd299fb79f6cee93bf21f926f0f9f8251 -- patch looks correct
in test/lint/lint-python.sh:47 in eff770fcd2 outdated
```
  43 | @@ -44,7 +44,6 @@ enabled=(
  44 |      E743 # do not define functions named "l", "O", or "I"
  45 |      E901 # SyntaxError: invalid syntax
  46 |      E902 # TokenError: EOF in multi-line string
  47 | -    F401 # module imported but unused
```
MarcoFalke commented at 12:27 PM on June 5, 2020:

why remove this check?

hebasto commented at 12:30 PM on June 5, 2020:

#18210 (comment)

MarcoFalke commented at 12:32 PM on June 5, 2020:

But why does travis not print this warning message?
hebasto commented at 1:13 PM on June 5, 2020:

False positive warnings due to the outdated local flake8 version:

$ pip3 show flake8 | grep Version Version: 3.5.0

Going to fix this pull now.
hebasto commented at 1:20 PM on June 5, 2020:

Updated.
test: Do not swallow flake8 exit code 7dda912e1c
doc: Add mypy to test dependencies 5d77549d8b
hebasto force-pushed on Jun 5, 2020
hebasto commented at 1:19 PM on June 5, 2020: member
Updated eff770fcd299fb79f6cee93bf21f926f0f9f8251 -> 5d77549d8b287eb773db695b88c165ebe3be1005 (pr19172.01 -> pr19172.02, diff):
- addressed @MarcoFalke's comment:
why remove this check?
MarcoFalke commented at 1:48 PM on June 5, 2020: member

Approach ACK 5d77549d8b287eb773db695b88c165ebe3be1005, fine with me
practicalswift commented at 6:15 AM on June 6, 2020: contributor

ACK 5d77549d8b287eb773db695b88c165ebe3be1005
fanquake merged this on Jun 6, 2020
fanquake closed this on Jun 6, 2020
hebasto deleted the branch on Jun 6, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#18210 test: type hints in Python tests