qt: Deduplicate NumConnections enum #19193

1. 
   hebasto commented at 5:35 pm on June 6, 2020: member

   There are two identical NumConnections enums in the code base:

   • enum NumConnections in qt/clientmodel.h was introduced in #3685
   • enum CConnman::NumConnections in net.h was introduced in #8085

   This PR drops the former enum in favor of the latter one.

2. refactor, qt, net: Deduplicate NumConnections enum 4147d7413b
3. MarcoFalke renamed this:
   refactor, qt, net: Deduplicate NumConnections enum
   qt: Deduplicate NumConnections enum
   on Jun 6, 2020
4. MarcoFalke added the label Refactoring on Jun 6, 2020
5. 
   practicalswift commented at 7:33 pm on June 6, 2020: contributor

   Concept ACK: DRY is good
6. 
   DrahtBot commented at 1:10 am on June 7, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

7. 
   laanwj commented at 12:50 pm on July 15, 2020: member

   Not sure about this architecturally, is the GUI allowed to use arbitrary core types, just like that? Or do they need to be moved to the interface header then? @ryanofsky
8. 
   hebasto commented at 9:53 am on September 11, 2020: member

   Closed in favor of https://github.com/bitcoin-core/gui/pull/86 #20172.
9. hebasto closed this on Sep 11, 2020

   ---

10. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto practicalswift DrahtBot laanwj

Labels
Refactoring