qt: Deduplicate NumConnections enum #19193

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200606-numconn changing 3 files +13 −26

hebasto commented at 5:35 PM on June 6, 2020: member
There are two identical NumConnections enums in the code base:
- enum NumConnections in qt/clientmodel.h was introduced in #3685
- enum CConnman::NumConnections in net.h was introduced in #8085
This PR drops the former enum in favor of the latter one.
refactor, qt, net: Deduplicate NumConnections enum 4147d7413b
MarcoFalke renamed this:
~~refactor, qt, net: Deduplicate NumConnections enum~~
qt: Deduplicate NumConnections enum
on Jun 6, 2020
MarcoFalke added the label Refactoring on Jun 6, 2020
practicalswift commented at 7:33 PM on June 6, 2020: contributor

Concept ACK: DRY is good
DrahtBot commented at 1:10 AM on June 7, 2020: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
laanwj commented at 12:50 PM on July 15, 2020: member

Not sure about this architecturally, is the GUI allowed to use arbitrary core types, just like that? Or do they need to be moved to the interface header then? @ryanofsky
hebasto commented at 9:53 AM on September 11, 2020: member

Closed in favor of ~https://github.com/bitcoin-core/gui/pull/86~ #20172.
hebasto closed this on Sep 11, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels